Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid, optionally with headers.

2019-09-23 Thread Dave Page
Hi Akshay, On Mon, Sep 23, 2019 at 4:10 PM Akshay Joshi wrote: > > > On Mon, Sep 23, 2019 at 4:58 PM Dave Page wrote: > >> >> >> On Mon, Sep 23, 2019 at 11:03 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Mon, Sep 23, 2019 at 3:16 PM Akshay Joshi < >>> aks

Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid, optionally with headers.

2019-09-23 Thread Akshay Joshi
On Mon, Sep 23, 2019 at 4:58 PM Dave Page wrote: > > > On Mon, Sep 23, 2019 at 11:03 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> On Mon, Sep 23, 2019 at 3:16 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Khushboo >>> >>> Following are the re

Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid, optionally with headers.

2019-09-23 Thread Dave Page
On Mon, Sep 23, 2019 at 11:03 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Mon, Sep 23, 2019 at 3:16 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Following are the review comments: >> >>- Copy with headers not working when we sele

Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid, optionally with headers.

2019-09-23 Thread Khushboo Vashi
Hi, On Mon, Sep 23, 2019 at 3:16 PM Akshay Joshi wrote: > Hi Khushboo > > Following are the review comments: > >- Copy with headers not working when we select a few rows. > > I have considered this option only with the entire grid but will fix this. So, If I select only 2 rows and also selec

Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid, optionally with headers.

2019-09-23 Thread Akshay Joshi
Hi Khushboo Following are the review comments: - Copy with headers not working when we select a few rows. - The dropdown should be disabled when the copy button is disabled. - When user select/de-select "Copy with headers" option dropdown should not be closed. It should be consistent

Re: [pgAdmin][RM4756] pgAdmin does not load completely if loaded in an iframe

2019-09-23 Thread Akshay Joshi
Thanks, patch applied. On Thu, Sep 19, 2019 at 5:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow pgAdmin to open in iframe. This patch also > fixes #4561 (which was rejected :P) where pgAdmin was not working when > opened using a

pgAdmin 4 commit: Fix issue where pgAdmin does not load completely if l

2019-09-23 Thread Akshay Joshi
Fix issue where pgAdmin does not load completely if loaded in an iframe. Fixes #4756 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=73dc130908506faf58c0ae1a172ac055685d9b9e Author: Aditya Toshniwal Modified Files -- docs/en_US/r