Re: [4696] Add RE-SQL/MSQL test cases for Materialized View

2019-09-05 Thread Akshay Joshi
Hi Fahar Below are the review comments: - Align test_msql.json file properly. - Give meaningful scenario names like "Alter MView comment, acl etc.." - Data for create and alter are identical, i am not sure what exactly you have changed. - Create/Alter test cases missing for With Da

Re: [4696] Add RE-SQL/MSQL test cases for Materialized View

2019-09-05 Thread Dave Page
Hi On Thu, Sep 5, 2019 at 9:09 AM Fahar Abbas wrote: > Hi Hackers, > > Please find attached the patch for RE-SQL for Materialized view. > > Please review and apply the patch. > - Please be consistent with your naming - you have scenarios that mention both mview and MView. Any reason not to call

[4696] Add RE-SQL/MSQL test cases for Materialized View

2019-09-05 Thread Fahar Abbas
Hi Hackers, Please find attached the patch for RE-SQL for Materialized view. Please review and apply the patch. Will send MSQL patch later. Kind Regards, -- Fahar Abbas QMG EnterpriseDB Corporation Phone Office: +92-51-835-8874 Phone Direct: +92-51-8466803 Mobile: +92-333-5409707 Skype ID: *li