pgAdmin 4 commit: Update yarn.lock to update the vulnerable javascripts

2019-09-03 Thread Ashesh Vashi
Update yarn.lock to update the vulnerable javascripts i.e. eslint-utils >= 1.4.1 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d4429fa64da4408f5479c68d07016de595f6bd4 Modified Files -- web/yarn.lock | 495 +++

Re: RE-SQL tests patch for packages node

2019-09-03 Thread Akshay Joshi
Thanks patch applied. On Tue, Sep 3, 2019 at 5:17 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Please check now. > > On Tue, Sep 3, 2019 at 5:07 PM Akshay Joshi > wrote: > >> Hi Navnath >> >> You forgot to add "create_package_with_all_options_msql.sql" and >> "alter_package_head

pgAdmin 4 commit: Added Modified SQL test cases for FTS Configurations.

2019-09-03 Thread Akshay Joshi
Added Modified SQL test cases for FTS Configurations. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=85baa22ca1f0e6c5d294a1b6d1f77e6f47723d5c Author: Ganesh Jaybhay Modified Files -- .../default/msql_alter_fts_conf_add_comment.sq

Re: [pgAdmin4][patch] MSQL test cases for FTS configurations

2019-09-03 Thread Akshay Joshi
Thanks patch applied. On Tue, Sep 3, 2019 at 5:15 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for msql test cases of FTS configurations. > Kindly review. > > Regards, > Ganesh Jaybhay > -- *Thanks & Regards* *Akshay Joshi* *Sr.

pgAdmin 4 commit: Added Modified SQL test cases for Packages.

2019-09-03 Thread Akshay Joshi
Added Modified SQL test cases for Packages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4690700a24f1b153d6d96d80429056051ae1a2ca Author: navnath gadakh Modified Files -- .../servers/databases/schemas/packages/__init__.py | 13

Re: RE-SQL tests patch for packages node

2019-09-03 Thread Akshay Joshi
Hi Navnath You forgot to add "create_package_with_all_options_msql.sql" and "alter_package_headers_and_comment_msql.sql" file in your patch. Please send the updated patch. On Tue, Sep 3, 2019 at 1:36 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi, > > Please find the modified p

Re: RE-SQL tests patch for packages node

2019-09-03 Thread navnath gadakh
Please check now. On Tue, Sep 3, 2019 at 5:07 PM Akshay Joshi wrote: > Hi Navnath > > You forgot to add "create_package_with_all_options_msql.sql" and > "alter_package_headers_and_comment_msql.sql" file in your patch. Please > send the updated patch. > > On Tue, Sep 3, 2019 at 1:36 PM navnath ga

[pgAdmin4][patch] MSQL test cases for FTS configurations

2019-09-03 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached patch for msql test cases of FTS configurations. Kindly review. Regards, Ganesh Jaybhay msql_fts_configuration.patch Description: Binary data

pgAdmin 4 commit: 1) Add Reverse Engineered and Modified SQL tests for

2019-09-03 Thread Akshay Joshi
1) Add Reverse Engineered and Modified SQL tests for Foreign Servers. Fixes #4617 2) Add Reverse Engineered and Modified SQL tests for User Mappings. Fixes #4627 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4745ad56e9f0253e8038889bc1765c213

Re: RE-SQL tests patch for packages node

2019-09-03 Thread navnath gadakh
Hi, Please find the modified patch. On Mon, Sep 2, 2019 at 5:43 PM Akshay Joshi wrote: > Hi Navnath > > Following are the review comments: > >- GRANT statement is not visible in RE-SQL for create and alter both. >(May be bug in Packages please fix that too) > > Done. > >- Delete pa