Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

2019-08-28 Thread Aditya Toshniwal
Hi Hackers, Kindly hold on with the patch. I think I have missed few things. :P Will send an updated patch. On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch containing further changes to sequences RE-SQL test > c

Re: [pgAdmin][RM4681] Increase cache control max age for static files

2019-08-28 Thread Avin Kavish
If content hashing is enabled on webpack, cache time can even be 10 years as the file names will update and effectively invalidate the old caches. If content hashing or some other cache busting mechanism is not enabled, it might be a problem. In my experience, it is good to have one year, browsers

Re: [pgAdmin][RM4681] Increase cache control max age for static files

2019-08-28 Thread Aditya Toshniwal
On Thu, Aug 29, 2019 at 10:59 AM Ashesh Vashi wrote: > On Wed, Aug 28, 2019 at 1:32 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to increase cache control max age (in http header) >> for static files to improve performance over lon

Re: [pgAdmin][RM4681] Increase cache control max age for static files

2019-08-28 Thread Ashesh Vashi
On Wed, Aug 28, 2019 at 1:32 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to increase cache control max age (in http header) > for static files to improve performance over longer run. > By default it is 43200 seconds (12 hrs), which means

Re: pgAdmin4 Feature Tests intermittent failures fix

2019-08-28 Thread Akshay Joshi
Thanks patch applied. On Tue, Aug 27, 2019 at 2:42 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Akshay, > > PFA the patch with fixed review comments. > > On Thu, Aug 22, 2019 at 4:26 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Yes, I agreed too. >> T

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

2019-08-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch containing further changes to sequences RE-SQL test cases. Changes include MSQL test cases, ACL test cases and allow run sequences test cases on EPAS servers. Kindly review. On Mon, Jul 15, 2019 at 7:26 PM Dave Page wrote: > Thanks, committed. > > On Mon, Jul

pgAdmin 4 commit: Further code refactoring to stabilise the Feature Tes

2019-08-28 Thread Akshay Joshi
Further code refactoring to stabilise the Feature Tests. Fixes #3936 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc4bef56a049de35c7202459c6e5167e555c70f7 Author: Shubham Agarwal Modified Files -- docs/en_US/release_notes_4_13.

Re: [pgAdmin][RM4381] Problem with data editing when using "View/Edit Data" to tables with OID

2019-08-28 Thread Akshay Joshi
Thanks patch applied. On Wed, Aug 28, 2019 at 12:21 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix an issue where, oid column should not be > pasted when copy/paste row is used on query output containing the oid > column. > > Kindly

pgAdmin 4 commit: Fix an issue where oid column should not be pasted wh

2019-08-28 Thread Akshay Joshi
Fix an issue where oid column should not be pasted when copy/paste row is used on query output containing the oid column. Fixes #4381 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=028473eb830a50b618bbfacdc924f4edb6d92a1a Author: Aditya Toshn

[pgAdmin][RM4681] Increase cache control max age for static files

2019-08-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to increase cache control max age (in http header) for static files to improve performance over longer run. By default it is 43200 seconds (12 hrs), which means that the static files like vendor.js, etc. will be fetched again from server after 12hrs. This is not r

pgAdmin 4 commit: 1) Add Reverse Engineered SQL tests for Views. Fixes

2019-08-28 Thread Akshay Joshi
1) Add Reverse Engineered SQL tests for Views. Fixes #4576 2) Ensure View should be created with special characters. Fixes #4486 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac298b03c0c06e2cfb3ab06b2c9d59a21f32bc0a Author: Usman Muzaffar M

Re: Resql test cases for views and fix for bug: 4650

2019-08-28 Thread Akshay Joshi
Thanks patch applied. On Tue, Aug 27, 2019 at 8:02 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi, > Please find here updated patch with the above required test cases. > > Please review and commit the changes > > On Tue, Aug 27, 2019 at 12:44 PM Akshay Joshi < > akshay.jo...@ent