Query Tool JS Minimal Refactoring

2019-08-16 Thread Yosry Muhammad
Hi hackers, Please find attached a patch with minimal refactoring of: web/pgadmin/tools/sqleditor/static/js/sqleditor.js This includes merging 2 redundant functions into one and renaming some functions to have more expressive and consistent names. Please review ! Thanks. -- *Yosry Muhammad Yosr

Release next week

2019-08-16 Thread Akshay Joshi
Hi Translators, We will have release next week, so updates to translations prior to release would be helpful. The template and catalogs have been updated in git. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246

pgAdmin 4 commit: Update message catalogs.

2019-08-16 Thread Akshay Joshi
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=177def1e580751198d60fad9a7bfe1bc1d271ff5 Modified Files -- web/pgadmin/messages.pot | 938 + .../translations/de/LC_MESSAGES

Re: [RM#4546] Add RE-SQL tests for Column node

2019-08-16 Thread Akshay Joshi
Thanks patch applied. On Fri, Aug 16, 2019 at 7:31 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello Akshay, > > On Fri, Aug 2, 2019 at 11:54 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Murtuza >> >> Following test cases are missing: >> >>- Primar

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Columns. Fixes #

2019-08-16 Thread Akshay Joshi
Add Reverse Engineered SQL tests for Columns. Fixes #4546 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f541200d98ed754cb6fd3d2a1b3f07dc547762a Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_12.rst

Re: [GSoC] Query History Upgrade

2019-08-16 Thread Yosry Muhammad
Thanks all for the thorough review. On Fri, Aug 16, 2019, 1:48 PM Akshay Joshi wrote: > Thanks patch applied. > > On Wed, Aug 14, 2019 at 7:24 PM Yosry Muhammad wrote: > >> Hi, >> >> On Wed, Aug 14, 2019 at 3:50 PM Yosry Muhammad >> wrote: >> >>> Please find an updated patch with the mentioned

Re: [GSoC] Query History Upgrade

2019-08-16 Thread Akshay Joshi
Thanks patch applied. On Wed, Aug 14, 2019 at 7:24 PM Yosry Muhammad wrote: > Hi, > > On Wed, Aug 14, 2019 at 3:50 PM Yosry Muhammad wrote: > >> Please find an updated patch with the mentioned issue fixed. I am sorry >> you spent so much time reviewing this and finding bugs. >> >> On Wed, Aug 1

pgAdmin 4 commit: Add support in query history to show internal queries

2019-08-16 Thread Akshay Joshi
Add support in query history to show internal queries generated by pgAdmin during save data operations. Fixes #4612 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=687204771ce936697508997fb7988ad8551b9b81 Author: Yosry Muhammad Modified File