Re: [GSoC] Query History Upgrade

Hi Yosry, On Mon, Aug 12, 2019 at 2:00 PM Yosry Muhammad wrote: > Hi Aditya, > > On Mon, Aug 12, 2019 at 9:04 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Yosry, >> >> Nice work there. It seems to be working fine except a few suggestions: >> 1) Fix pep8 issues >> 2)

pgAdmin 4 commit: Fix PEP8 issue

Fix PEP8 issue Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4403f326e9979b6ca7ca8cd4671b71785e1d41a3 Modified Files -- web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py | 3 ++- 1 file changed, 2 insertions(+),

pgAdmin 4 commit: Fix generation of reverse engineered SQL for Rules. F

Fix generation of reverse engineered SQL for Rules. Fixes #4586 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=35bbee3023d3559940f84fafb33cb13429eb3b15 Modified Files -- docs/en_US/images/rule_commands.png| Bin 0 -

pgAdmin 4 commit: Fix issue in drag drop feature. It's regression of RM

Fix issue in drag drop feature. It's regression of RM #4552 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a51de7829229fe03719fabac824d110ea0a95f0a Author: Aditya Toshniwal Modified Files -- web/pgadmin/tools/sqleditor/static/js/

Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors

Thanks patch applied. On Mon, Aug 12, 2019 at 12:22 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > This seemed to have disabled the drag drop feature. Attached is a minor > fix to reenable it. > > On Fri, Aug 2, 2019 at 3:59 PM Dave Page wrote: > >> Thanks, pat

Re: [GSoC] Query History Upgrade

Hi Yosry, Nice work there. It seems to be working fine except a few suggestions: 1) Fix pep8 issues 2) DOM Statements like below can be avoided and html can be added directly to main template of $el instead of adding extra operations of find, prepend and append. Plus, it makes it difficult to unde