pgAdmin 4 commit: Update library inventory.

2019-08-02 Thread Dave Page
Update library inventory. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d7ee4bb932462cef82ff80d5d052bef90ba970b4 Modified Files -- libraries.txt | 773 +++--- 1 file changed, 356

pgAdmin 4 commit: Add various make targets for auditing the Python and

2019-08-02 Thread Dave Page
Add various make targets for auditing the Python and JS modules. Update the install-node target so that it de-dupes JS modules. Original patch by Aditya, with further work from Ashesh and I. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=878

pgAdmin 4 commit: Fix some errors thrown on the JS console when draggin

2019-08-02 Thread Dave Page
Fix some errors thrown on the JS console when dragging text in the Query Tool. Fixes #4552 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=99a8b70e006bd64634b75433aa7b7699a6f0fd2b Author: Aditya Toshniwal Modified Files -- docs/e

Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors

2019-08-02 Thread Dave Page
Thanks, patch applied. On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue where dragging a selected text in > SQL editor throws console errors and does not move the text. > > As an improvement, the p

Re: [Help] Modifying get_columns.sql template

2019-08-02 Thread Yosry Muhammad
Alright, thanks a lot ! On Fri, Aug 2, 2019, 10:01 AM Dave Page wrote: > Hi Yosry, > > On Fri, Aug 2, 2019 at 7:51 AM Yosry Muhammad wrote: > >> Hi hackers! >> >> I was wondering if modifying the query in: get_columns.sql @ >> pgadmin/tools/sqleditor/templates/sql/default/ >> to also SELECT att

Re: Ensure View Data mode fetches next rows on scrolling through results when appropriate. Fixes #4536.

2019-08-02 Thread Dave Page
Thanks, patch applied! On Fri, Aug 2, 2019 at 5:38 AM Yosry Muhammad wrote: > Hi all, > > Please find a patch attached that: > > Ensure View Data mode fetches next rows on scrolling through results when > appropriate. Fixes #4536. > > Thanks. > -- > *Yosry Muhammad Yosry* > > Computer Engineerin

pgAdmin 4 commit: Fix load on demand in View/Edit data mode. Fixes #453

2019-08-02 Thread Dave Page
Fix load on demand in View/Edit data mode. Fixes #4536 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0cfd76c2795466d9b7d08ccc10c273bfcef80dae Author: Yosry Muhammad Modified Files -- docs/en_US/release_notes_4_12.rst

pgAdmin 4 commit: Use the full tab space for CodeMirror instances on di

2019-08-02 Thread Dave Page
Use the full tab space for CodeMirror instances on dialogues where appropriate. Fixes #4540 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=537c27a58ebeaaf7bc2edce48698746b5b6ceb89 Author: Akshay Joshi Modified Files -- docs/en_U

Re: [pgAdmin4][Patch]: Feature #4540 Change the design of the Code tab/block wherever applicable

2019-08-02 Thread Dave Page
Thanks, patch applied. On Thu, Aug 1, 2019 at 9:49 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to change the design of the code tab/block wherever > applicable. By doing this Code will be more readable. I have also updated > the documentation and screenshots. > > Please review

Re: [Help] Modifying get_columns.sql template

2019-08-02 Thread Dave Page
Hi Yosry, On Fri, Aug 2, 2019 at 7:51 AM Yosry Muhammad wrote: > Hi hackers! > > I was wondering if modifying the query in: get_columns.sql @ > pgadmin/tools/sqleditor/templates/sql/default/ > to also SELECT attnum (attribute number) in addition to the already > SELECTed columns will break any c