[Help] Modifying get_columns.sql template

Hi hackers! I was wondering if modifying the query in: get_columns.sql @ pgadmin/tools/sqleditor/templates/sql/default/ to also SELECT attnum (attribute number) in addition to the already SELECTed columns will break any code or tests? I know this template is used in multiple places throughout the

Re: [RM#4546] Add RE-SQL tests for Column node

Hi Murtuza Following test cases are missing: - Primary Key column. - Variable options. - Precision and Collation. - Identity column with 'GENERATED AS BY DEFAULT'. - ALTER column with identity values like CYCLE, minimum, maximum etc.. instead of updating comments in such test ca

[pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors

Hi Hackers, Attached is the patch to fix the issue where dragging a selected text in SQL editor throws console errors and does not move the text. As an improvement, the patch also fixes a potential issue where importing jquery.event.drag will override drag events and will break drag and drop feat

Ensure View Data mode fetches next rows on scrolling through results when appropriate. Fixes #4536.

Hi all, Please find a patch attached that: Ensure View Data mode fetches next rows on scrolling through results when appropriate. Fixes #4536. Thanks. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021.

Re: pgAdmin 4 commit: Ensure command tags are shown in the messages tab of

Sigh. Well I can't fix the commit message, but I have updated the correct ticket. Thanks. On Thu, Aug 1, 2019 at 2:39 PM Yosry Muhammad wrote: > I think this fixes #4525 not #4520. > > On Thu, Aug 1, 2019, 9:29 AM Dave Page wrote: > >> Ensure command tags are shown in the messages tab of the Q

Re: [pgAdmin][RM4229] Missing "Copy" (and other edit menu items) from data panels

Thanks, applied. On Thu, Aug 1, 2019 at 6:42 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Kindly ignore the previous patch. Attached it the updated patch to move > wcDocker to latest version. > This will also solve #4489 - Empty modal window. > > On Thu, Aug 1

pgAdmin 4 commit: Update wcDocker to allow the browser's context menu t

Update wcDocker to allow the browser's context menu to be used except in tab strips and panel headers. Fixes #4229 Update wcDocker to prevent window state loading creating blank dialogues. Fixes #4489 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commit

Re: Query Tool Fix

Thanks, all applied. On Wed, Jul 31, 2019 at 10:30 PM Yosry Muhammad wrote: > Please find separate patch files attached. I believe there isn't any > dependency between the patches. > > #4525 and #4529 are duplicates - both are fixed by the patch. > > On Wed, Jul 31, 2019 at 3:49 PM Dave Page wr

Re: pgAdmin 4 commit: Ensure command tags are shown in the messages tab of

I think this fixes #4525 not #4520. On Thu, Aug 1, 2019, 9:29 AM Dave Page wrote: > Ensure command tags are shown in the messages tab of the Query Tool. Fixes > #4520 > > Branch > -- > master > > Details > --- > > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76e658ee12

pgAdmin 4 commit: Ensure the Query Tool doesn't throw an error when vie

Ensure the Query Tool doesn't throw an error when viewing the contents of a table with no columns. Fixes #4492 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=97e39699ead1005a4a5ef8e986d980df8f743db9 Author: Yosry Muhammad Modified Files ---

pgAdmin 4 commit: Ensure command tags are shown in the messages tab of

Ensure command tags are shown in the messages tab of the Query Tool. Fixes #4520 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76e658ee129a49afc74152b57330cf2c2e653e2e Author: Yosry Muhammad Modified Files -- docs/en_US/release_

pgAdmin 4 commit: Ensure the query tool will work with older versions o

Ensure the query tool will work with older versions of psycopg2 than we officially support, albeit without updateable resultsets. Fixes #4520 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b65507533ac1e505786d04378f709451fbddfdf Author: Yosr

pgAdmin 4 commit: PEP-8 fix.

PEP-8 fix. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbe40176c1f604dddf8543b40ef5afca733cbc34 Modified Files -- web/pgadmin/feature_tests/xss_checks_panels_and_query_tool_test.py | 2 +- 1 file changed, 1 insertion(+), 1 delet

pgAdmin 4 commit: Ensure type names are properly encoded in the results

Ensure type names are properly encoded in the results grid. Fixes #4401 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bcb1392a1a77b5bd6791039bcc241941f5dec522 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4

Re: [RM#4546] Add RE-SQL tests for Column node

Hi All I'll review this patch and give my review comments. On Wed, Jul 31, 2019 at 4:10 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add RE-SQL tests for Column node. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com >

pgAdmin 4 commit: Allow a banner to be displayed on the login and other

Allow a banner to be displayed on the login and other related pages showing custom text. Fixes #4549 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a8a28e4f90dba9ecd3be46cd8768db66c8e5456 Modified Files -- docs/en_US/release_not