Re: pgAdmin4 v4.11 candidate builds

2019-07-22 Thread Fahar Abbas
Thanks for sharing candidate builds. On Tue, Jul 23, 2019 at 10:32 AM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.11 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-07-23-1/ > > Fahar, can you please verify it for release on Thursday. > > -- > *Thanks &

pgAdmin4 v4.11 candidate builds

2019-07-22 Thread Akshay Joshi
Hi All, pgAdmin4 v4.11 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-07-23-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +9

pgAdmin 4 commit: Update version for release

2019-07-22 Thread Akshay Joshi
Update version for release Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4d9fea83d8b06fc1d836ca948f047dab7143695 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files c

Re: Bug in Database Nodes in the Tree

2019-07-22 Thread Khushboo Vashi
On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad wrote: > Hi, > > I tried just removing the lines responsible for connecting to the database > on selecting a database node and it seem to work fine. Specifically the > lines 254-257 in database.js (callbacks.selected function). > > Are there any spec

Re: Dual Dialogs

2019-07-22 Thread Khushboo Vashi
Hi Avin, On Mon, Jul 22, 2019 at 6:49 PM Avin Kavish wrote: > Hey Hackers, > > I'm getting dual dialogs when closing a query window. Even though it says > "leave site?", I'm only closing a single panel and not closing the tab. It > doesn't actually kill the tab, only the panel but still a bit an

Re: Bug in Database Nodes in the Tree

2019-07-22 Thread Yosry Muhammad
Hi, I tried just removing the lines responsible for connecting to the database on selecting a database node and it seem to work fine. Specifically the lines 254-257 in database.js (callbacks.selected function). Are there any specific scenarios I need to test to make sure everything is okay? Anywh

Re: [pgAdmin4][Patch] - RM 4427 , RM 4484, RM 4485

2019-07-22 Thread Akshay Joshi
Thanks patch applied. On Mon, Jul 22, 2019 at 3:51 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix below RMs: > > #4427 - Cannot View Retrieve Records From 1 Table > #4484 - Query Tool - Explain & Explain Analyze are broken > #4485 - Vi

pgAdmin 4 commit: 1) Fix an error while retrieving json data from the t

2019-07-22 Thread Akshay Joshi
1) Fix an error while retrieving json data from the table. Fixes #4427 2) Fix an issue where Explain and Explain Analyze are not working, it's regression of #1760. Fixes #4484 3) Fix an issue where Filter toolbar button is not working in view/edit data, it's regression of keyboard navigation. Fix

Dual Dialogs

2019-07-22 Thread Avin Kavish
Hey Hackers, I'm getting dual dialogs when closing a query window. Even though it says "leave site?", I'm only closing a single panel and not closing the tab. It doesn't actually kill the tab, only the panel but still a bit annoying. Fyi, I'm on v4.8. [image: Screenshot from 2019-07-22 09-03-07.p

Re: Translators: Release next week

2019-07-22 Thread Akshay Joshi
Thanks patch applied. On Mon, Jul 22, 2019 at 4:44 PM wrote: > hello > french translation for upcoming release > Fred > > > -- > *De: *"Akshay Joshi" > *À: *"pgadmin-hackers" > *Envoyé: *Vendredi 19 Juillet 2019 14:18:54 > *Objet: *Translators: Release next week > >

pgAdmin 4 commit: Update French translation

2019-07-22 Thread Akshay Joshi
Update French translation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e49c9c36f2b169cc855bf203b7f51f3907a1efa Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 160764 -> 172056

Re: Translators: Release next week

2019-07-22 Thread fred . escallier
hello french translation for upcoming release Fred - Mail original - De: "Akshay Joshi" À: "pgadmin-hackers" Envoyé: Vendredi 19 Juillet 2019 14:18:54 Objet: Translators: Release next week Hi Translators, We will have release next week, so updates to translations prior to

[pgAdmin4][Patch] - RM 4427 , RM 4484, RM 4485

2019-07-22 Thread Khushboo Vashi
Hi, Please find the attached patch to fix below RMs: #4427 - Cannot View Retrieve Records From 1 Table #4484 - Query Tool - Explain & Explain Analyze are broken #4485 - View Data - Filter Data is broken This issues are the regression of below commits: 74cfeabd02c8fd63d2604ac826dae7ed4308a91e 7

Re: [pgAdmin4][Patch] - RM #4333 - Add support for function selectivity.

2019-07-22 Thread Dave Page
On Mon, Jul 22, 2019 at 9:59 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jul 22, 2019 at 2:07 PM Dave Page wrote: > >> Hi >> >> In the Trigger and Type dialogues when selecting a function we give a >> combo box listing all the functions in the database that match the

Re: [pgAdmin4][Patch] - RM #4333 - Add support for function selectivity.

2019-07-22 Thread Khushboo Vashi
On Mon, Jul 22, 2019 at 2:07 PM Dave Page wrote: > Hi > > In the Trigger and Type dialogues when selecting a function we give a > combo box listing all the functions in the database that match the required > signature. Can't we do this here as well? > Support function should have specific argumen

Re: Skip a RE-SQL test on the bases of precondition

2019-07-22 Thread Dave Page
Thanks, patch applied. On Sun, Jul 21, 2019 at 6:31 PM Nagesh Dhope wrote: > Hi Hackers, > Please find patch for skipping a RE-SQL test if precondition to execute > that test does not satisfy. > > -- > Thanks, > Nagesh > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake Enterp

pgAdmin 4 commit: Add support for pre-condition SQL in RE-SQL testsuite

2019-07-22 Thread Dave Page
Add support for pre-condition SQL in RE-SQL testsuite, and use it to ensure that the right extensions are installed for the extension tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1813eca1ca0942b1a7e334c6017a9e10d906ae97 Author: Nagesh

Re: [pgAdmin4][Patch] - RM #4333 - Add support for function selectivity.

2019-07-22 Thread Dave Page
Hi In the Trigger and Type dialogues when selecting a function we give a combo box listing all the functions in the database that match the required signature. Can't we do this here as well? On Fri, Jul 19, 2019 at 9:54 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please