Re: [GSoC] Finalized First Patch

2019-07-04 Thread Dave Page
Hi Apologies for the delay - I've finished travelling now. I found a few issues, mostly minor: - The patch won't apply with "git apply" and only partially applies with patch -p0. Please "git add" all your changes and new files in your repo, and then run "git diff --cached --binary", which should

Re: [pgAdmin4][Patch]: RM 4393 Edit users with parameters 'all' gives error while saving

2019-07-04 Thread Dave Page
Thanks, committed. On Thu, Jul 4, 2019 at 9:29 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #4393 Edit users with parameters 'all' > gives error while saving. Apart from that I have modified the function > qtIdent, qtTypeIdent and qtLiteral to handle integer value. >

pgAdmin 4 commit: Ensure parameter values are quoted when needed when e

2019-07-04 Thread Dave Page
Ensure parameter values are quoted when needed when editing roles. Fixes #4393 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=776884860e11d15b6bb1db5e094a4cd728a84fd9 Author: Akshay Joshi Modified Files -- docs/en_US/release_note

Re: [pgAdmin][RM4429] Drag and Drop name in query tool is not working for Firefox browser

2019-07-04 Thread Dave Page
Thanks, applied. On Wed, Jul 3, 2019 at 1:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix drag and drop issue on firefox. Had to make > few code changes required by firefox explicitly :/ > > Kindly review. > > -- > Thanks and Regar

pgAdmin 4 commit: Ensure drag/drop from the treeview works as expected

2019-07-04 Thread Dave Page
Ensure drag/drop from the treeview works as expected on Firefox. Fixes #4429 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0aa18fd466dbadf040152965781ae5033f4a26af Author: Aditya Toshniwal Modified Files -- docs/en_US/release_no

Re: [pgAdmin][RM4318] Change CSS cursors to reflect locked layout level

2019-07-04 Thread Dave Page
Thanks, committed. On Wed, Jul 3, 2019 at 10:59 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to update wcDocker to latest version where the fix > for changing CSS cursors when layout is locked is merged. > > Do not forget to yarn install

pgAdmin 4 commit: Set the mouse cursor appropriately based on the layou

2019-07-04 Thread Dave Page
Set the mouse cursor appropriately based on the layout lock state. Fixes #4318 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15427334af3e89ca17d166ed9115caf85f0e0145 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_

pgAdmin 4 commit: Use our own doc theme.

2019-07-04 Thread Dave Page
Use our own doc theme. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3487b3360e5eee7af89fb8e48e398ef4ac7aa346 Modified Files -- docs/en_US/conf.py | 40 +- docs/en_US/theme/pgadmin4/layout.html|

pgAdmin 4 commit: Update the version number in release note.

2019-07-04 Thread Akshay Joshi
Update the version number in release note. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fabb644230249d6bdc4424fa4d5a9442f47a709a Modified Files -- docs/en_US/release_notes_4_11.rst | 2 +- 1 file changed, 1 insertion(+), 1 deleti

pgAdmin 4 v4.10 released

2019-07-04 Thread Akshay Joshi
The pgAdmin Development Team are pleased to announce pgAdmin 4 version 4.10. This release of pgAdmin 4 includes over 6 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_10.html. pgAdmin is the leading Open S

pgAdmin 4 commit: Fix table icon issue when updating any existing field

2019-07-04 Thread Akshay Joshi
Fix table icon issue when updating any existing field. Fixes #4437 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf1f9a4b077f398d76bd83fb6f0f30e2524faaf6 Modified Files -- docs/en_US/release_notes_4_11.rst

Re: pgAdmin4 v4.10 candidate builds

2019-07-04 Thread Fahar Abbas
One Round of testing has been completed for pgadmin4 4.10 and we can release it. On Tue, Jul 2, 2019 at 9:27 PM Akshay Joshi wrote: > Hi Fahar, > > Candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-07-02-3/ > Please verify the upgrade scenario and rest of t

Re: passwords enabled by default

2019-07-04 Thread Dave Page
Great, thanks. Can you now test it in a container? I think you'll need to map the file location in the container to the host machine, and then specify the location in the container (e.g. /pgpass in the example below) when you configure the server in pgAdmin. e.g. docker run -p 80:80 \ -e "

Re: passwords enabled by default

2019-07-04 Thread Fahar Abbas
Yes Dave it's working as expected. On Thu, Jun 27, 2019 at 8:16 PM Dave Page wrote: > Fahar, can you verify that the Password File option works as expected (or > not) in a non-containerised environment? It should *not* require PGPASSFILE > to be set (because that's basically what it should be do

[pgAdmin4][Patch]: RM 4393 Edit users with parameters 'all' gives error while saving

2019-07-04 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #4393 Edit users with parameters 'all' gives error while saving. Apart from that I have modified the function qtIdent, qtTypeIdent and qtLiteral to handle integer value. Please review it -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *