Re: passwords enabled by default

Fahar, can you verify that the Password File option works as expected (or not) in a non-containerised environment? It should *not* require PGPASSFILE to be set (because that's basically what it should be doing for us). Thanks. On Thu, Jun 27, 2019 at 8:27 AM Andrew Coleman wrote: > Recently, wh

Re: change to Docker entrypoint.sh

On Thu, Jun 27, 2019 at 8:12 AM Andrew Coleman wrote: > > > On Fri, Jun 21, 2019 at 4:24 AM Dave Page wrote: > >> Hi >> >> On Thu, Jun 20, 2019 at 5:31 PM Andrew Coleman >> wrote: >> >>> Hi All! >>> >>> I am new to this, so I apologize beforehand if it's not entirely kosher, >>> but I have a pr

pgAdmin 4 commit: Allow the path to /pgadmin4/servers.json to be overri

Allow the path to /pgadmin4/servers.json to be overridden in the container distribution. Fixes #4400 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d397959f6aa6e54a1b3d0481325b7289e4e43e1a Author: Andrew Coleman Modified Files -

pgAdmin 4 commit: Prevent an error that may occur when editing data wit

Prevent an error that may occur when editing data with an integer primary key. Fixes #4404 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da8cf1404745d051c384513a8fded81ae5e65fed Author: Aditya Toshniwal Modified Files -- docs/e

pgAdmin 4 commit: Ensure the browser close confirmation is only shown w

Ensure the browser close confirmation is only shown when closing a Query Tool which is running in a separate browser tab. Fixes #4403 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2451db87978c3bd43fb6350f990cc0e49c7928bb Author: Aditya Toshn

Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

Thanks, applied. On Thu, Jun 27, 2019 at 6:32 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch based on the review comments in > trailing mail. > Kindly review. > > On Wed, Jun 26, 2019 at 5:09 PM Dave Page wrote: > >> >> >> On Wed,

pgAdmin 4 commit: Allow some objects to be dragged/dropped into the Que

Allow some objects to be dragged/dropped into the Query Tool to insert their signature into the query text. Fixes #4139 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=173b812b932aecede3dfe610977d8307fa5165bc Author: Aditya Toshniwal Modifie

Re: feature tests fix

Thanks, applied. On Thu, Jun 27, 2019 at 4:19 AM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for feature test fix for test case > xss_checks_panels_and_query_tool_test. > It fixes the following issues. > >- The query tool element

pgAdmin 4 commit: Feature test fixes:

Feature test fixes: The query tool element while running on jenkins, is present on the DOM but not visible due to comparatively small page size. So handle it , would work in both cases(if element is visible or not). The tab name handles XSS characters due to which table name is shown modified

passwords enabled by default

Recently, while testing my changes to entrypoint.sh in Docker, I noticed that you cannot import or export passwords via the servers.json file. You can get around this by setting the PassFile option in servers.json, but that still doesn't work correctly. For me to make this work, I had to also set t

Re: change to Docker entrypoint.sh

On Fri, Jun 21, 2019 at 4:24 AM Dave Page wrote: > Hi > > On Thu, Jun 20, 2019 at 5:31 PM Andrew Coleman > wrote: > >> Hi All! >> >> I am new to this, so I apologize beforehand if it's not entirely kosher, >> but I have a proposed change to the Dockerfile entrypoint.sh to allow for >> configurab

Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

Hi On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: > >> Hi >> >> Something isn't working correctly - I turned on the summary option, and >> this is the query that was run when I hit the EXPLA

pgAdmin 4 v4.9 released

The pgAdmin Development Team are pleased to announce pgAdmin 4 version 4.9. This release of pgAdmin 4 includes over 27 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_9.html. pgAdmin is the leading Open So

Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

Hi Hackers, Attached is the updated patch based on the review comments in trailing mail. Kindly review. On Wed, Jun 26, 2019 at 5:09 PM Dave Page wrote: > > > On Wed, Jun 26, 2019 at 7:38 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, Jun 26, 2019 at 5:

Re: pgAdmin4 v4.9 candidate builds

Hi Akshay, pgadmin4 v4.9 candidate builds are ready for the release. Kind Regards, On Tue, Jun 25, 2019 at 2:24 AM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.9 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-06-24-1/ > > Fahar, can you please verify

feature tests fix

Hi Hackers, Please find here attached patch for feature test fix for test case xss_checks_panels_and_query_tool_test. It fixes the following issues. - The query tool element while running on jenkins, is present on the DOM but not visible due to comparatively small page size. So handle it ,