Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-17 Thread Akshay Joshi
Hi Dave/Hackers Attached is the modified patch to fix the given review comments. Please review it. On Mon, Jun 17, 2019 at 2:29 PM Dave Page wrote: > > > On Mon, Jun 17, 2019 at 9:41 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Mon, Jun 17, 2019 at 1:33 PM Dav

Re: [pgAdmin][RM4306] Please log in to access the page Message displayed unnecessarily

2019-06-17 Thread Dave Page
Thanks, patch applied. On Mon, Jun 17, 2019 at 12:33 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will suppress unnecessary "Please log in to access the > page" flash messages on the login page. > > Kindly review. > > -- > Thanks and Regards, >

pgAdmin 4 commit: Prevent the "Please login to access this page" messag

2019-06-17 Thread Dave Page
Prevent the "Please login to access this page" message displaying multiple times. Fixes #4306 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=71919a4ce9c78ed7d341367df8e8a169c11e7d23 Modified Files -- docs/en_US/release_notes_4_9.

[pgAdmin][RM4306] Please log in to access the page Message displayed unnecessarily

2019-06-17 Thread Aditya Toshniwal
Hi Hackers, Attached patch will suppress unnecessary "Please log in to access the page" flash messages on the login page. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4306.patch Description: Bi

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-17 Thread Dave Page
Hi On Sun, Jun 16, 2019 at 3:10 PM Yosry Muhammad wrote: > This is a patch fixing a problem with the above patch that happened when: > - primary key columns are renamed. > - other columns are renamed to be like primary key columns. > > This problem happened mainly because the primary keys are id

Re: [pgAdmin][RM3174] Distinguish simple tables from tables that are inherited and from which other tables are inherited

2019-06-17 Thread Dave Page
Thanks, applied. On Mon, Jun 17, 2019 at 7:32 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to change icons for table inheritance (icons by > Chethana Kumar) > Along with this, I have also fixed few other issues/icons found on the way: > 1

pgAdmin 4 commit: Change icons for table inheritance (icons by Chethana

2019-06-17 Thread Dave Page
Change icons for table inheritance (icons by Chethana Kumar) Fixes #3174 Along with this, I have also fixed few other issues/icons found on the way: 1) Dependencies tab for inherited tables/foreign keys shows partial text (Fixes ##3994). 2) Dependencies tab for child partition table shows parent

I would like the old header back

2019-06-17 Thread Avin Kavish
Hi, I would like the options to switch back to the old two-tone header with the elephant please. #saveTheElephant

Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-17 Thread Dave Page
On Mon, Jun 17, 2019 at 9:41 AM Akshay Joshi wrote: > Hi Dave > > On Mon, Jun 17, 2019 at 1:33 PM Dave Page wrote: > >> >> >> On Mon, Jun 17, 2019 at 8:19 AM Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> >>> On Mon, Jun 17, 2019 at 11:54 AM Akshay Joshi < >>> akshay.jo...@enterp

Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-17 Thread Akshay Joshi
Hi Dave On Mon, Jun 17, 2019 at 1:33 PM Dave Page wrote: > > > On Mon, Jun 17, 2019 at 8:19 AM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Mon, Jun 17, 2019 at 11:54 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave/Hackers >>> >>> On Fri, Jun 14, 20

Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-17 Thread Dave Page
On Mon, Jun 17, 2019 at 8:19 AM Ashesh Vashi wrote: > > On Mon, Jun 17, 2019 at 11:54 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave/Hackers >> >> On Fri, Jun 14, 2019 at 6:10 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Fri, Jun 14, 2019 at

pgAdmin 4 commit: Fix help links for backup globals and backup server.

2019-06-17 Thread Akshay Joshi
Fix help links for backup globals and backup server. Fixes #4365 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf548dda3f5a383474e0f4f57544a75e35a2084a Modified Files -- docs/en_US/release_notes_4_9.rst

Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-17 Thread Ashesh Vashi
On Mon, Jun 17, 2019 at 11:54 AM Akshay Joshi wrote: > Hi Dave/Hackers > > On Fri, Jun 14, 2019 at 6:10 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Fri, Jun 14, 2019 at 1:59 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Jun 13, 2019 at 12:52 PM Akshay Joshi < >>> aksh