Re: [pgAdmin][Doc] Master password doc change to add reference to desktop deployment

2019-06-05 Thread Dave Page
Thanks, applied with some other changes and re-wording. On Wed, Jun 5, 2019 at 1:51 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to add link reference to "Desktop > Deployment"(where configuration related stuff is present) in master >

pgAdmin 4 commit: Clarify warnings about disabling the master password.

2019-06-05 Thread Dave Page
Clarify warnings about disabling the master password. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e69188588104222f2e30680152250b9d124f304a Modified Files -- docs/en_US/master_password.rst | 13 + 1 file changed, 9 in

pgAdmin 4 commit: Clarify docs around configuration files and disabling

2019-06-05 Thread Dave Page
Clarify docs around configuration files and disabling the master password. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=caf181d5e34c223ca703e242552dda3989d76dc6 Modified Files -- docs/en_US/desktop_deployment.rst | 8 ++-- d

[pgAdmin][Doc] Master password doc change to add reference to desktop deployment

2019-06-05 Thread Aditya Toshniwal
Hi Hackers, Attached is a tiny patch to add link reference to "Desktop Deployment"(where configuration related stuff is present) in master password help page. Might be helpful for people who don't know how to configure. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Ind

Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button

2019-06-05 Thread Aditya Toshniwal
Hi, On Wed, Jun 5, 2019 at 4:48 PM Dave Page wrote: > Hi > > On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix an issue where using browser autofills in >> alertify dialogs triggers the help page butt

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-06-05 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated, rebased patch. I was using the wrong key code for "[" and "]" while registering, but strangely it was working for me. I have corrected that. Plus, I found a bug in Preferences. If a preference name is same in two different modules, then it was registered only o

Re: Is requirements.txt up2date?

2019-06-05 Thread Dave Page
Hi On Wed, Jun 5, 2019 at 12:59 PM Devrim Gündüz wrote: > > Hi, > > I recently hit by some missing or not up2date Python modules while > building/installing pgAdmin4. > > Recent one is Werkzeug, and I also hit an issue with blinker. Both of > these do > not appear in requirements.txt. Are we sur

Is requirements.txt up2date?

2019-06-05 Thread Devrim Gündüz
Hi, I recently hit by some missing or not up2date Python modules while building/installing pgAdmin4. Recent one is Werkzeug, and I also hit an issue with blinker. Both of these do not appear in requirements.txt. Are we sure that this list is up2date? Cheers, -- Devrim Gündüz Open Source Soluti

Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button

2019-06-05 Thread Dave Page
Hi On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix an issue where using browser autofills in > alertify dialogs triggers the help page button (#4317). > A workaround was added to master password dialog to a

Re: [RM4255] Geometry Viewer captures keys in Firefox, Edge and Internet Explorer

2019-06-05 Thread Dave Page
Thanks, applied. On Tue, Jun 4, 2019 at 6:54 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix a focus issue in geometry view for browsers > other than chrome. > If geometry viewer is not visible (in wcDocker) and it loses focus, then >

pgAdmin 4 commit: Prevent the geometry viewer grabbing key presses when

2019-06-05 Thread Dave Page
Prevent the geometry viewer grabbing key presses when not in focus under Firefox, IE and Edge. Fixes #4255 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d90136d93d91e68db03f0d3e7ca19165335a0cce Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin][RM4035] ELSIF not correctly highlighted in editor

2019-06-05 Thread Akshay Joshi
Thanks patch applied. On Wed, Jun 5, 2019 at 11:39 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to use the latest version of CodeMirror, to make > sure that the fix is available. > > On Wed, Jun 5, 2019 at 11:29 AM Aditya Toshniwal < > ad

Re: [pgAdmin4][RM3936] - Fixes for feature test due to changes in pgadmin4

2019-06-05 Thread Dave Page
See https://www.pgadmin.org/support/list/ or the headers in every email on the list for info on how to manage your subscription. On Tue, Jun 4, 2019 at 4:03 PM Cleber da Silva wrote: > Morning, how are you guys? > > Sorry, but I am no longer want to be part of this list. Could you, please, > tak

[pgAdmin][RM4310] User can not connect to the Master Password with Enter button

2019-06-05 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix an issue where using browser autofills in alertify dialogs triggers the help page button (#4317). A workaround was added to master password dialog to avoid this, but that in turn disabled the 'OK' button tigger on pressing enter button. This is also fixed w