Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-21 Thread Aditya Toshniwal
Hi, Attached is the updated patch with doc changes. On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, May 21, 2019 at 5:32 PM Dave Page wrote: > >> Hi >> >> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < >> aditya.toshni...@enter

[pgAdmin][RM4263] "Not connected to the server or the connection to the server has been closed." returned with some queries

2019-05-21 Thread Aditya Toshniwal
Hi Hackers, Attached is the quick fix for the issue. The problem was with parsing failure of JSON result in explain plan code. I have added an api test case to check length of result format to match with JS code expectations for explain plan. Kindly review. -- Thanks and Regards, Aditya Toshniwa

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-21 Thread Aditya Toshniwal
Hi, On Tue, May 21, 2019 at 5:32 PM Dave Page wrote: > Hi > > On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the accessibility issue in query tool. >> >> The query tool can be completely restruct

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-21 Thread Dave Page
Hi On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the accessibility issue in query tool. > > The query tool can be completely restructured unlike previously where > query tool used to stick at top and ot

pgAdmin 4 commit: Validate permissions on the session directory itself,

2019-05-21 Thread Dave Page
Validate permissions on the session directory itself, not it's parent, per Felix Pusch. Fixes #4276 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1ef7b0346cbb06ca007bdf48f7830fbcac2b2a1 Modified Files -- web/pgadmin/setup/data_

pgAdmin 4 commit: Clarify wording for the NO INHERIT option on constrai

2019-05-21 Thread Dave Page
Clarify wording for the NO INHERIT option on constraints, per Michel Feinstein. Fixes #4275 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ee50ac248d4433c914735d79782e6fad0a4ac8f Modified Files -- docs/en_US/check_dialog.rst

[pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-21 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix the accessibility issue in query tool. The query tool can be completely restructured unlike previously where query tool used to stick at top and other tabs in the bottom. - I have added a new shortcut to switch between frames if in query tool the tab posit