Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-17 Thread Akshay Joshi
Thanks patch applied. On Thu, Apr 18, 2019 at 9:31 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Tue, Apr 16, 2019 at 1:05 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Following are m

pgAdmin 4 commit: 1) Fix an issue where Deleting N number of rows makes

2019-04-17 Thread Akshay Joshi
1) Fix an issue where Deleting N number of rows makes first N number of rows disable. Fixes #3605 2) Ensure that on clicking Delete button should not delete rows immediately from the database server, it should be deleted when Save button will be clicked. Fixes #2392 Branch -- master Deta

[pgAdmin][RM4134] Tablespace location shows error "Location cannot be empty" in the pgAdmin 4

2019-04-17 Thread Aditya Toshniwal
Hi Hackers, Attached is a tiny patch to fix the error "Location cannot be empty" in Tablespace dialog, which occurs even if Location is disabled in edit mode. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tr

Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-17 Thread Khushboo Vashi
Hi Akshay, Please find the attached updated patch. On Tue, Apr 16, 2019 at 1:05 PM Akshay Joshi wrote: > Hi Khushboo > > Following are my review comments: > >- Jasmine test case are failing. > > This is due to the Slickgrid upgrade. I will send the separate patch for the same. > >- Cre

pgAdmin 4 commit: Ensure sanity of the permissions on the storage and s

2019-04-17 Thread Dave Page
Ensure sanity of the permissions on the storage and session directories and the config database. Fixes #4182 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d728ee7436be86917f3cfac1c7f109ed521b1fe4 Modified Files -- docs/en_US/rel

[pgAdmin][RM4101] No confirmation before window refresh in query tabs

2019-04-17 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to ask for confirmation before reload if query tool or debugger is opened in a new tab. I have also fixed a small issue where debugger is not opening in new tab. The datagrid/close URL which is called when query tool is closed was called with GET method, which is