Re: [pgAdmin4][Patch]: RM #4100 Unable to create sequence with Increment, Start, Minimum and Maximum value

2019-03-22 Thread Dave Page
Thanks, patch applied. On Fri, Mar 22, 2019 at 1:51 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #4100 "Unable to create sequence with > Increment, Start, Minimum and Maximum value". > > Please review it. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software

pgAdmin 4 commit: Ensure sequences can be created with increment, start

2019-03-22 Thread Dave Page
Ensure sequences can be created with increment, start, minimum and maximum options set. Fixes #4100 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=212ca01506f02d62bedc37d5c6af8f209b7486cc Author: Akshay Joshi Modified Files -- d

pgAdmin 4 commit: Fix SQL help for EPAS 10+, and refactor the URL gener

2019-03-22 Thread Dave Page
Fix SQL help for EPAS 10+, and refactor the URL generation code into a testable function. Fixes #4099 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce073a28562a3045ac86ae65eefeeed3b65f Modified Files -- docs/en_US/release_no

[pgAdmin4][Patch]: RM #4100 Unable to create sequence with Increment, Start, Minimum and Maximum value

2019-03-22 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #4100 "Unable to create sequence with Increment, Start, Minimum and Maximum value". Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_4100.pat

Re: RM3887 - User storage home folder collision

2019-03-22 Thread Dave Page
Thanks to you and Khushboo. Committed. On Fri, Mar 22, 2019 at 5:04 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Looks good to me. > > On Thu, Mar 21, 2019 at 10:41 PM Dave Page wrote: > >> Here's a patch to fix and repair $SUBJECT. >> >> Anyone see any issues with it? >> >>

Re: [pgAdmin] - RM-3936 -Feature tests patch

2019-03-22 Thread Dave Page
Hi Also, can you fix the encoding test patches to use a randomised database name while you're at it? Jenkins just fell over due to concurrency issues. Thanks. On Thu, Mar 21, 2019 at 12:21 PM Dave Page wrote: > Hi > > Awesome job (and they're much faster now!) - patch committed (but there's >

pgAdmin 4 commit: Use the user's full email address (not just the usern

2019-03-22 Thread Dave Page
Use the user's full email address (not just the username part) as the basis for the storage directory name.. Fixes #3887 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae23f146d1063a3fac7195d8caffd79b6c0004d0 Modified Files -- do

Re: "yarn run pep8" excludes config file

2019-03-22 Thread Dave Page
On Fri, Mar 22, 2019 at 8:52 AM Akshay Joshi wrote: > Hi Hackers > > After latest pull when I run "*yarn run pep8*" from *web* directory it is > not working properly. Path of the ".pycodestyle" config file is not correct > in package.json. Attached is the patch to fix that. > Wow, why do we even

pgAdmin 4 commit: Fix the PEP8 yarn runner

2019-03-22 Thread Dave Page
Fix the PEP8 yarn runner Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=096220ece9504c15a06d2b5519dce25b008dc057 Modified Files -- web/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

"yarn run pep8" excludes config file

2019-03-22 Thread Akshay Joshi
Hi Hackers After latest pull when I run "*yarn run pep8*" from *web* directory it is not working properly. Path of the ".pycodestyle" config file is not correct in package.json. Attached is the patch to fix that. Please review it -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *E