Re: [pgAdmin4][RM4054] Wrong Message displayed on Query tool window if user create table without column

2019-03-07 Thread Dave Page
Thanks, applied. On Thu, Mar 7, 2019 at 12:10 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is tiny patch to fix wrong Message displayed on Query tool window > if user create table without column. > I came across this when running just "select" and fou

pgAdmin 4 commit: Handle resultsets with zero columns correctly in the

2019-03-07 Thread Dave Page
Handle resultsets with zero columns correctly in the Query Tool. Fixes #4054 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6aae9d6e202c2f03280b0660b9b18954137b12bb Author: Aditya Toshniwal Modified Files -- docs/en_US/release_n

pgAdmin 4 commit: Include the license in the docs, and ensure it gets u

2019-03-07 Thread Dave Page
Include the license in the docs, and ensure it gets updated each year. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8b9a86e9588839fb03d88351d7abba29549bc9d Modified Files -- LICENSE| 2 +- docs/en_US/licence

pgAdmin 4 commit: Some more doc restructuring and cleanup.

2019-03-07 Thread Dave Page
Some more doc restructuring and cleanup. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47bce4eb235b0780287efd4bfffe2258163ae4ea Modified Files -- docs/en_US/getting_started.rst | 2 +- docs/en_US/{browser.rst => us

pgAdmin 4 commit: Some doc restructuring and cleanup.

2019-03-07 Thread Dave Page
Some doc restructuring and cleanup. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64ee23a08889a06154aa31dd9e8c2a204e581237 Modified Files -- docs/en_US/browser.rst | 2 +- docs/en_US/debugger.rst

pgAdmin 4 commit: Tag REL-4_3 has been created.

2019-03-07 Thread Akshay Joshi
Tag REL-4_3 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_3 Log Message --- Tag v4.3

[pgAdmin4][RM4054] Wrong Message displayed on Query tool window if user create table without column

2019-03-07 Thread Aditya Toshniwal
Hi Hackers, Attached is tiny patch to fix wrong Message displayed on Query tool window if user create table without column. I came across this when running just "select" and found the issue been already reported. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | Enterpr

Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React

2019-03-07 Thread Khushboo Vashi
On Thu, Mar 7, 2019 at 4:34 PM Dave Page wrote: > > > On Thu, Mar 7, 2019 at 11:02 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 7, 2019 at 4:23 PM Dave Page wrote: >> >>> Thanks - committed. Oddly, having removed a bunch of files and 88 JS >>> dependencies

Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React

2019-03-07 Thread Dave Page
On Thu, Mar 7, 2019 at 11:02 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Mar 7, 2019 at 4:23 PM Dave Page wrote: > >> Thanks - committed. Oddly, having removed a bunch of files and 88 JS >> dependencies, the resulting Python package is actually slightly bigger! >> >

Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React

2019-03-07 Thread Khushboo Vashi
On Thu, Mar 7, 2019 at 4:23 PM Dave Page wrote: > Thanks - committed. Oddly, having removed a bunch of files and 88 JS > dependencies, the resulting Python package is actually slightly bigger! > And now I have conflicts in around 40 files. :) > > On Thu, Mar 7, 2019 at 9:46 AM Aditya Toshniwal <

pgAdmin 4 v4.3 released

2019-03-07 Thread Akshay Joshi
The pgAdmin Development Team are pleased to announce pgAdmin 4 version 4.3. This release of pgAdmin 4 includes over 38 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_3.html. pgAdmin is the leading Open So

Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React

2019-03-07 Thread Dave Page
Thanks - committed. Oddly, having removed a bunch of files and 88 JS dependencies, the resulting Python package is actually slightly bigger! On Thu, Mar 7, 2019 at 9:46 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to remove React dependen

pgAdmin 4 commit: Remove the large and unnecessary dependency on React

2019-03-07 Thread Dave Page
Remove the large and unnecessary dependency on React and 87 other related libraries. Fixes #4018 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b895941b337925e95d32cef39a44d80c232cc0e Author: Aditya Toshniwal Modified Files --

Re: pgAdmin4 v4.3 candidate builds

2019-03-07 Thread Fahar Abbas
Hi Akshay! One Round of testing has been completed. Can you please publish pgAdmin4 v4.3? Kind Regards, On Mon, Mar 4, 2019 at 6:20 PM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.3 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-03-04-2/ > > Fahar, ca