Re: [pgAdmin4][Patch]: RM #3933 Error dropping database pop up message displayed if user try to drop any database with Arabic character with non super user

2019-02-27 Thread Akshay Joshi
Hi Dave On Wed, Feb 27, 2019 at 10:08 PM Dave Page wrote: > Hi > > On Wed, Feb 27, 2019 at 7:50 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #3933 "Error dropping database pop up >> message displayed if user try to drop any data

Re: [pgAdmin4][Patch] - Encoding Fixes

2019-02-27 Thread Khushboo Vashi
On Wed, Feb 27, 2019 at 4:57 PM Dave Page wrote: > Hi > > On Tue, Feb 26, 2019 at 9:01 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the encoding related issues. >> >> #3992 - View data causes errors with DB encoding EUC_JIS_200

Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)

2019-02-27 Thread Khushboo Vashi
Hi Dave, On Wed, Feb 27, 2019 at 4:30 PM Dave Page wrote: > Hi > > Thanks - that fixed the double scrollbar, but not the other issue. Any > ideas on that one? > Can you please provide the exact steps to reproduce the second issue as after fixing the first one I can't reproduce it. Thanks, Khush

pgAdmin 4 commit: Use POST instead of GET for Query Tool downloads to a

2019-02-27 Thread Dave Page
Use POST instead of GET for Query Tool downloads to avoid errors with long queries. Fixes #4013 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=acb61f0990ac0926719a43508903fa6fa5141732 Modified Files -- web/pgadmin/tools/sqleditor

Re: [pgAdmin4][Patch]: RM #3933 Error dropping database pop up message displayed if user try to drop any database with Arabic character with non super user

2019-02-27 Thread Dave Page
Hi On Wed, Feb 27, 2019 at 7:50 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #3933 "Error dropping database pop up > message displayed if user try to drop any database with Arabic character > with non super user". There is an exception in the logging system for > Arab

Re: [pgAdmin4][RM3587] Browser rendering of a bigint in a jsonb is wrong

2019-02-27 Thread Dave Page
Thanks, patch applied. On Wed, Feb 27, 2019 at 7:09 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. As mentioned earlier, jsonb will be fetched > as text. Only when the pop up editor opens, json-bignumber parser will be > used to pr

pgAdmin 4 commit: Fix support for bigint's in JSONB data. Fixes #3587

2019-02-27 Thread Dave Page
Fix support for bigint's in JSONB data. Fixes #3587 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6e7cf0f69ca8f3b78bdf8d214b45c5665159f89 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_3.rst

Re: [pgAdmin4][Patch] - Encoding Fixes

2019-02-27 Thread Dave Page
Hi On Tue, Feb 26, 2019 at 9:01 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the encoding related issues. > > #3992 - View data causes errors with DB encoding EUC_JIS_2004 > #3982 - Encoding Problem with PGAdmin 4.2 > #3911 - Data out

Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)

2019-02-27 Thread Dave Page
Hi Thanks - that fixed the double scrollbar, but not the other issue. Any ideas on that one? On Wed, Feb 27, 2019 at 5:52 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached fix. > I have added the configurable option to add the extra classes in th

pgAdmin 4 commit: Fix double scrollbar on the query tool results grid.

2019-02-27 Thread Dave Page
Fix double scrollbar on the query tool results grid. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b3a628e7a9bb4948e6076336d845474f45eae98 Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/static/js/panel.js