Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-19 Thread Khushboo Vashi
Hi Dave, On Tue, Feb 19, 2019 at 7:27 PM Dave Page wrote: > Hi > > I did some testing with this and found a couple of issues: > > - The toolbar isn't set correctly when the query is running. I can still > use buttons to modify the query for example (like indent selection), and > the cancel butto

[pgAdmin4][RM3912] Unable to save data if user update primary key with Json data type

2019-02-19 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix the issue where updating data (using view/edit) of primary key column where data type of that column is json/jsonb throws exception psycopg2.ProgrammingError: can't adapt type ' dict'. The adapt function of psycopg2 does not support dict data type. Instead,

PGAdmin 4 don't refresh server info after restarting

2019-02-19 Thread Andrey Klychkov
Hello, We've noticed that pgadmin 3.x / 4.x doesn't refresh server info like server version after restarting. Sometimes, it makes people confused. For example, 1. PgAdmin was running 2. We upgraded postgres from 11.1 to 11.2 3. PgAdmin was restarted 4. We continued to see 11.1 5. We must push "Di

[pgAdmin4][RM3912] Unable to save data if user update primary key with Json data type

2019-02-19 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix the issue where updating data (using view/edit) of primary key column where data type of that column is json/jsonb throws exception psycopg2.ProgrammingError: can't adapt type ' dict'. The adapt function of psycopg2 does not support dict data type. Instead,

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-19 Thread Dave Page
Hi I did some testing with this and found a couple of issues: - The toolbar isn't set correctly when the query is running. I can still use buttons to modify the query for example (like indent selection), and the cancel button is not enabled. - I ran a very large query which generated millions of

Re: [Patch]: Minor change in dependency_inventory file to generate library file

2019-02-19 Thread Dave Page
Thanks, applied. On Tue, Feb 19, 2019 at 4:11 AM Neel Patel wrote: > Hi, > > Please find attached patch to handle JSON object properly to avoid error > like "the JSON object must be str, not 'bytes'" while generating > library.txt file. > > Verified with both python2 and python3. Do review it an

pgAdmin 4 commit: Convert the JSON output from yarn properly

2019-02-19 Thread Dave Page
Convert the JSON output from yarn properly Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ccb079631709d13712353dc32c9e53f0209f63b9 Author: Neel Patel Modified Files -- tools/dependency_inventory.py | 6 +- 1 file changed, 5 in