Re: Replace PyCrypto by cryptography

2019-01-31 Thread Dave Page
Thanks, patch applied. On Wed, Jan 30, 2019 at 8:55 PM Cyril Jouve wrote: > > Hello, > > this removes the PyCrypto dependency and replace it by cryptography (3272). > > Regards, > Cyril -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.

pgAdmin 4 commit: Replace the PyCrypto module with the cryptography mod

2019-01-31 Thread Dave Page
Replace the PyCrypto module with the cryptography module. Fixes #3272 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b786c4c140434d26b0bacbd8d79bae1bf28b7ec5 Author: Cyril Jouve Modified Files -- Make.bat

Re: [pgAdmin4][RM3865] Difficult to resize Query Tool

2019-01-31 Thread Dave Page
On Wed, Jan 30, 2019 at 10:17 AM Akshay Joshi wrote: > Hi Dave > > On Wed, Jan 30, 2019 at 2:32 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> I was having conversation with Aditya about "What should be the mouse >> hover (resize selection) area of the splitters?".

pgAdmin 4 commit: Ensure we use PIP 18.1 in the Docker build because of

2019-01-31 Thread Dave Page
Ensure we use PIP 18.1 in the Docker build because of https://github.com/pypa/pip/issues/6197 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbfa614cf9fa8d784a6e15c33651d2da1a6be36d Modified Files -- pkg/docker/Dockerfile | 4 +++

pgAdmin 4 commit: Expose the bind address in the Docker container via P

2019-01-31 Thread Dave Page
Expose the bind address in the Docker container via PGADMIN_BIND_ADDRESS. Fixes #3955 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da3b3de39773733ed4438e159cdc966eb861dffb Author: Diego Augusto Molina Modified Files -- docs/en

Re: Remove python 2.6 specific code

2019-01-31 Thread Dave Page
Thanks - patch applied with a minor change for PEP8 compliance. On Wed, Jan 30, 2019 at 8:51 PM Cyril Jouve wrote: > > Hi, > > Since python 2.6 is deprecated, this patch removes python 2.6 specific code. > > Regards, > Cyril -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake En

pgAdmin 4 commit: Remove Python 2.6 code that's now obsolete. Fixes #39

2019-01-31 Thread Dave Page
Remove Python 2.6 code that's now obsolete. Fixes #3935 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbd8f8236a7bfc36fc8747cd1bdb96b4a8437ee4 Author: Cyril Jouve Modified Files -- docs/en_US/release_notes_4_2.rst

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-31 Thread Akshay Joshi
Thanks patch applied. On Thu, Jan 31, 2019 at 4:05 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Ashesh, > > The patch looks good to me. > > On Thu, Jan 31, 2019 at 3:34 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, Jan 31, 2019 at 2:38 PM Aditya To

pgAdmin 4 commit: Remove hacky way to open/close the dropdown submenu

2019-01-31 Thread Akshay Joshi
Remove hacky way to open/close the dropdown submenu Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38feacd04d50bf4f0afbdb98c962a03078295a23 Author: Ashesh Vashi Modified Files -- web/pgadmin/browser/static/js/browser.js | 1 - we

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-31 Thread Aditya Toshniwal
Hi Ashesh, The patch looks good to me. On Thu, Jan 31, 2019 at 3:34 PM Ashesh Vashi wrote: > On Thu, Jan 31, 2019 at 2:38 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Ashesh, >> >> All works good, except one small change. Submenus should be closed if I >> press Esc

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-31 Thread Ashesh Vashi
On Thu, Jan 31, 2019 at 2:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Ashesh, > > All works good, except one small change. Submenus should be closed if I > press Esc and then reopen the menu. > Please find the updated patch to resolve the review comments. -- Thanks, As

Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

2019-01-31 Thread Akshay Joshi
Thanks patch applied with the mentioned changes. On Thu, Jan 31, 2019 at 2:26 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Khushboo, > > The patch looks good to me and statistics works great now. Tested with > 2000 tables. > However, I did not get what did the below change

pgAdmin 4 commit: Fixed Statistics panel hang issue for 1000+ tables. F

2019-01-31 Thread Akshay Joshi
Fixed Statistics panel hang issue for 1000+ tables. Fixes #3664 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6244463ac1f0bc5e9d6ce53f60855dc0cb94da9b Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_2.rst

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-31 Thread Aditya Toshniwal
Hi Ashesh, All works good, except one small change. Submenus should be closed if I press Esc and then reopen the menu. On Thu, Jan 31, 2019 at 11:32 AM Ashesh Vashi wrote: > Hi Aditya, > > On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi As

Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

2019-01-31 Thread Aditya Toshniwal
Hi Khushboo, The patch looks good to me and statistics works great now. Tested with 2000 tables. However, I did not get what did the below change do. *diff --git a/web/pgadmin/misc/statistics/static/js/statistics.js b/web/pgadmin/misc/statistics/static/js/statistics.js* *index cfd573e1..5441f883