pgAdmin 4 commit: Remove icon for 'Refresh View' context menu of Materi

2019-01-30 Thread Akshay Joshi
Remove icon for 'Refresh View' context menu of Materialized View and Added label for Definition control for consistency. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2afa3d82671272d785dda0d83d492499086c0071 Modified Files -- ..

Re: [pgAdmin4][Patch] RM 3899 - Unable to Drop Rules for table and foreign table through properties section

2019-01-30 Thread Akshay Joshi
Thanks patch applied. On Thu, Jan 31, 2019 at 11:46 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 3899 - Unable to Drop Rules > for table and foreign table through properties section. > > Another minor issue fixed with this patc

pgAdmin 4 commit: Fixed unable to drop multiple Rules and Foreign Table

2019-01-30 Thread Akshay Joshi
Fixed unable to drop multiple Rules and Foreign Tables from properties tab. Fixes #3899 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b35aaa1d74e3b190dc4aceb70564a56b00b8c4e Author: Khushboo Vashi Modified Files -- docs/en_US/

pgAdmin 4 commit: Update yarn lockfile.

2019-01-30 Thread Akshay Joshi
Update yarn lockfile. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1bce0b5eef1bef046148a9c8adc4496cad00de9c Modified Files -- web/yarn.lock | 1501 + 1 file changed, 2 inser

[pgAdmin4][Patch] RM 3899 - Unable to Drop Rules for table and foreign table through properties section

2019-01-30 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 3899 - Unable to Drop Rules for table and foreign table through properties section. Another minor issue fixed with this patch is - while adding/editing the foreign table, the foreign server cache level has not getting updated that has been fixed no

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-30 Thread Ashesh Vashi
Hi Aditya, On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Ashesh, > > I am getting a syntax error on bundle. > After fixing that, please look into this scenario: > Using keyboard shortcuts open object menu, for eg on table node. Go to any > sub

pgAdmin 4 commit: Correct schema should be displayed in Materialized Vi

2019-01-30 Thread Akshay Joshi
Correct schema should be displayed in Materialized View dialog. Fixes #3916 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0bb4f005e54e701890488ea5093b895b8d1ae4f8 Modified Files -- docs/en_US/release_notes_4_2.rst

Replace PyCrypto by cryptography

2019-01-30 Thread Cyril Jouve
Hello, this removes the PyCrypto dependency and replace it by cryptography (3272 ). Regards, Cyril 0001-replace-PyCrypto-by-cryptography.patch Description: Binary data

Remove python 2.6 specific code

2019-01-30 Thread Cyril Jouve
Hi, Since python 2.6 is deprecated , this patch removes python 2.6 specific code. Regards, Cyril 0001-remove-python-2.6-compatibility-code.patch Description: Binary data

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

2019-01-30 Thread Akshay Joshi
Hi Aditya I have applied your patch but following test cases are failing consistently: - CopySelectedQueryResultsFeatureTest - QueryToolAutoCompleteFeatureTest I have verified your patch on Mac OSX and Ubuntu. Chrome Version 71.0.3578.98 On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi wrote

Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-30 Thread Akshay Joshi
Thanks patch applied. On Wed, Jan 30, 2019 at 3:10 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > On Mon, Jan 28, 2019 at 4:38 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Murtuza >> >> Here are my review comments: >> >>- Exact error should be

pgAdmin 4 commit: Handle backend errors properly and display them corre

2019-01-30 Thread Akshay Joshi
Handle backend errors properly and display them correctly on GUI for Grant Wizard Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=317a04eafcd4e19e6e47a5c29614ada05a074b2d Author: Murtuza Zabuawala Modified Files -- web/pgadmin/st

[pgAdmin4[RM#3948] Fix backform note control style

2019-01-30 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3948.diff Description: Binary data

pgAdmin 4 commit: Fixed debugger issue for procedure inside package for

2019-01-30 Thread Akshay Joshi
Fixed debugger issue for procedure inside package for EPAS servers. Fixes #3927 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e489df7b0b69c2b6131adc4e0648b1ffa5c4e3a Modified Files -- docs/en_US/release_notes_4_2.rst | 1

Re: [pgAdmin4][RM3865] Difficult to resize Query Tool

2019-01-30 Thread Akshay Joshi
Hi Dave On Wed, Jan 30, 2019 at 2:32 PM Ashesh Vashi wrote: > Hi Dave, > > I was having conversation with Aditya about "What should be the mouse > hover (resize selection) area of the splitters?". > I asked him to set it to 5px. > I have committed with 7px which looks good, but it would be

Re: [pgAdmin4][RM3865] Difficult to resize Query Tool

2019-01-30 Thread Ashesh Vashi
Hi Dave, I was having conversation with Aditya about "What should be the mouse hover (resize selection) area of the splitters?". I asked him to set it to 5px. But - he has different opinion, was in favor to keep it around '11px'. Please advise. -- Thanks & Regards, Ashesh Vashi EnterpriseDB I

Re: [pgAdmin4][RM3865] Difficult to resize Query Tool

2019-01-30 Thread Akshay Joshi
Thanks patch applied. On Wed, Jan 30, 2019 at 12:32 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > With my pull request for changes in wcDocker merged ( > https://github.com/EnterpriseDB/wcDocker/commit/9cf81f03bb350b76b77a264f1db5d55391d5e424), > we are now abl

pgAdmin 4 commit: Increase frames splitter mouse hover area to make it

2019-01-30 Thread Akshay Joshi
Increase frames splitter mouse hover area to make it easier to resize. Fixes #3865 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ab094e8f160d6174d4d27cd78b0ceecf97ea0cb0 Author: Aditya Toshniwal Modified Files -- docs/en_US/rel

Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package

2019-01-30 Thread Khushboo Vashi
The patch looks good to me. On Wed, Jan 30, 2019 at 1:05 PM Akshay Joshi wrote: > Hi Khushboo > > On Wed, Jan 30, 2019 at 10:17 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> The issue has been fixed with this patch but I feel we need code >> refactoring of t