Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package

Hi Khushboo On Wed, Jan 30, 2019 at 10:17 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > The issue has been fixed with this patch but I feel we need code > refactoring of the existing code especially the loop in which we find the > required string. > What's your thou

[pgAdmin4][RM3865] Difficult to resize Query Tool

Hi Hackers, With my pull request for changes in wcDocker merged ( https://github.com/EnterpriseDB/wcDocker/commit/9cf81f03bb350b76b77a264f1db5d55391d5e424), we are now able to increase the mouse hover area of the frame splitters without increasing visible splitter lines width. Attached is the patc

pgAdmin 4 commit: Show the help string separate block in the calendar c

Show the help string separate block in the calendar control to align the input, and calendar button properly in case of help string is present. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e8f8042790c7d68f20e0d468d06ed533daad08f Modified F

pgAdmin 4 commit: Increase the width, and show the pointer cursor of th

Increase the width, and show the pointer cursor of the button under the sortable backgrid header Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=430be1c4cb5989c0f87c32a8f2cb1b23b2089192 Modified Files -- web/pgadmin/static/scss/_ba

pgAdmin 4 commit: Override the font-family defined by bootstrap

Override the font-family defined by bootstrap Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1858596253a765f5ac4652871d97d48a21bd3240 Modified Files -- web/pgadmin/static/scss/resources/_default.variables.scss | 8 +--- 1 file

Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package

Hi Akshay, The issue has been fixed with this patch but I feel we need code refactoring of the existing code especially the loop in which we find the required string. What's your thought? Also, please remove the datagrid/__init__.py file from the patch which I assume you have sent by mistake. Th

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

On Tue, 29 Jan 2019, 19:09 Dave Page Akshay, can you look at this please? > Sure. > > On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal > wrote: > > > > Hi Hackers, > > > > Attached is the updated patch. I have changed fill_input_by_field_name > function to use javascript to set values of te

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

Akshay, can you look at this please? On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is the updated patch. I have changed fill_input_by_field_name > function to use javascript to set values of text boxes and the selector is > changed from xpath to CSS with a

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

Hi Hackers, Attached is the updated patch. I have changed fill_input_by_field_name function to use javascript to set values of text boxes and the selector is changed from xpath to CSS with a :not(:disabled) clause. With this, test case will fail if tried to set the value of a disabled input. Kind

Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output

On Tue, Jan 29, 2019 at 6:27 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > The patch looks good to me. > Thanks patch applied. > > On Tue, Jan 29, 2019 at 4:54 PM Dave Page wrote: > >> Aditya, can you review this please? Once you're happy, Akshay can commi

pgAdmin 4 commit: Ensure that output of the query should be displayed e

Ensure that output of the query should be displayed even if Data Output window is detached from the Query Tool. Fixes #3697 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fedbcd404519519b17767e9486895cc0a8e0bf75 Modified Files --

Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output

Hi Akshay, The patch looks good to me. On Tue, Jan 29, 2019 at 4:54 PM Dave Page wrote: > Aditya, can you review this please? Once you're happy, Akshay can commit. > > On Tue, Jan 29, 2019 at 9:35 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the p

Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output

Aditya, can you review this please? Once you're happy, Akshay can commit. On Tue, Jan 29, 2019 at 9:35 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM 3697 Detached Data Output Tab (Windows) > does not show Select output. Please review it. > > -- > *Akshay Joshi* > > *Sr

Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package

Khushboo, can you review this please? If you're happy with it, Akshay can commit. Thanks. On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi wrote: > > Hi Hackers, > > Attached is the patch to fix RM 3927 "Unable to debug the procedure inside > package". Problem with the existing code is we assume t

Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

Hi, Please find the attached updated patch. I have also improved the performance of the properties tab. Please also apply the bootstrap toggle patch to check the properties tab performance. Thanks, Khushboo On Tue, Jan 22, 2019 at 5:05 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wro

[pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output

Hi Hackers, Attached is the patch to fix RM 3697 Detached Data Output Tab (Windows) does not show Select output. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3697.patch Description: Binary data