Re: [pgAdmin4][Patch]: Fix syntax error on pytthon 2.7 for the feature test

2019-01-23 Thread Akshay Joshi
Thanks patch applied. On Thu, Jan 24, 2019 at 11:12 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the syntax error on python 2.7 for > the feature test case. > The cause of this is the print function is not compatible with python 2.7 >

pgAdmin 4 commit: Fix syntax error on python 2.7 for the feature test.

2019-01-23 Thread Akshay Joshi
Fix syntax error on python 2.7 for the feature test. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4fe31404c82129e567aa0a350f03fa0151c329c Author: Khushboo Vashi Modified Files -- web/pgadmin/feature_tests/xss_checks_panels_and

Re: 4.1 bytecompile error on RHEL 7

2019-01-23 Thread Khushboo Vashi
On Wed, Jan 23, 2019 at 8:54 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Jan 23, 2019 at 10:38 PM Devrim Gündüz wrote: > >> >> Hi, >> >> I'm seeing this at the end of the RPM build process on RHEL 7. Please >> note that >> 3.6 passes here: >> >> =

[pgAdmin4][Patch]: Fix syntax error on pytthon 2.7 for the feature test

2019-01-23 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the syntax error on python 2.7 for the feature test case. The cause of this is the print function is not compatible with python 2.7 which has been fixed. Thanks, Khushboo diff --git a/web/pgadmin/feature_tests/xss_checks_panels_and_query_tool_test.py b/we

Re: 4.1 bytecompile error on RHEL 7

2019-01-23 Thread Khushboo Vashi
On Wed, Jan 23, 2019 at 10:38 PM Devrim Gündüz wrote: > > Hi, > > I'm seeing this at the end of the RPM build process on RHEL 7. Please note > that > 3.6 passes here: > > == > + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 > Bytecompiling .py f

4.1 bytecompile error on RHEL 7

2019-01-23 Thread Devrim Gündüz
Hi, I'm seeing this at the end of the RPM build process on RHEL 7. Please note that 3.6 passes here: == + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 Bytecompiling .py files below /var/lib/pgsql/rpm11/BUILDROOT/pgadmin4-4.1- 1.rhel7.x86_64/us

pgAdmin 4 commit: 1) Messages tab of query tool should be clear on subs

2019-01-23 Thread Akshay Joshi
1) Messages tab of query tool should be clear on subsequent execution of table/view using View/Edit Data. Fixes #3608 2) Clear drop-down menu should be disabled for View/Edit Data. Fixes #3609 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3

pgAdmin 4 commit: Ensure we set the fixed port options properly when co

2019-01-23 Thread Dave Page
Ensure we set the fixed port options properly when configuring following an error. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08cf2c83109317b3d22587d3113ea97f82d64fa9 Modified Files -- runtime/pgAdmin4.cpp | 6 ++ 1 file c

Re: backup accessecibility

2019-01-23 Thread Aditya Toshniwal
Apologies. Kindly ignore. On Wed, Jan 23, 2019 at 3:54 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > PFA > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- Thanks and

backup accessecibility

2019-01-23 Thread Aditya Toshniwal
PFA -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" backup.access.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near

2019-01-23 Thread Akshay Joshi
Thanks patch applied. On Wed, Jan 23, 2019 at 2:23 PM Akshay Joshi wrote: > Sorry, it's working. I'll review and commit it. > > On Wed, Jan 23, 2019 at 2:16 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Patch not working when procedure is created with arguments

pgAdmin 4 commit: Fixed EXEC script for procedures. Fixes #3850

2019-01-23 Thread Akshay Joshi
Fixed EXEC script for procedures. Fixes #3850 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=406ada10f54c6ccc86660a77d6d1ef0f0752efc3 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_2.rst |

Re: [pgAdmin4][Patch] - RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near

2019-01-23 Thread Akshay Joshi
Sorry, it's working. I'll review and commit it. On Wed, Jan 23, 2019 at 2:16 PM Akshay Joshi wrote: > Hi Khushboo > > Patch not working when procedure is created with arguments. Can you please > verify it. > > On Wed, Jan 23, 2019 at 12:59 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> w

Re: [pgAdmin4][Patch] - RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near

2019-01-23 Thread Akshay Joshi
Hi Khushboo Patch not working when procedure is created with arguments. Can you please verify it. On Wed, Jan 23, 2019 at 12:59 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 3850 - EXEC script generates > incorrect syntax: ERRO