Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

On Thu, Dec 20, 2018 at 4:48 PM Dave Page wrote: > Hi > > On Thu, Dec 20, 2018 at 10:09 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Thu, Dec 20, 2018 at 3:08 PM Dave Page wrote: >> >>> Hi >>> >>> When testing with quoting set to None, quote = " and delimiter =

Re: [pgAdmin 4][Patch]: RM 3559 - Far too many mouse clicks to drill down in Browser

On Thu, Dec 20, 2018 at 4:01 PM Dave Page wrote: > Hi > > On Tue, Dec 18, 2018 at 9:46 AM Khushboo Vashi > wrote: > > > > Hi, > > > > Please find the attached patch to fix the issue reported in RM #3559 > (Far too many mouse clicks to drill down in Browser) related to Tree Save > State. > > This

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

Hi On Thu, Dec 20, 2018 at 10:09 AM Akshay Joshi wrote: > Hi Dave > > On Thu, Dec 20, 2018 at 3:08 PM Dave Page wrote: > >> Hi >> >> When testing with quoting set to None, quote = " and delimiter = , I get >> the following exception when I try to download: >> >> 2018-12-20 09:34:02,547: SQL pga

Re: [pgAdmin] [RM#3831] Utility script to update copyright information

Hi Thanks - committed with a few minor changes: - Message tweaks - Don't lose the comma after the second year, or the tool will only work once - Put it in a new utilities/ directory - Scan .pro and .plist files as well. On Thu, Dec 20, 2018 at 7:55 AM Murtuza Zabuawala wrote: > > Hi Dave, > > Pl

pgAdmin 4 commit: Don't lose the comma!

Don't lose the comma! Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f62d35bf3c92a643c7d7f07b89df7ddff56bbf93 Modified Files -- tools/copyright_updater.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Use the standard copyright string.

Use the standard copyright string. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2df00fc0527a83b30bad4f1b7f4215afea34557 Modified Files -- web/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[pgAdmin4][RM3830] AttributeError if pgadmin4-web-setup.sh stopped in between login setup and run again

Hi Hackers, Attached is patch to fix the exception "AttributeError: 'NoneType' object has no attribute 'value'", which occurs when you stop(Ctrl+Z or Ctrl+C) pgadmin4-web-setup.sh script while entering details for login and then run pgadmin4-web-setup.sh again. pgAdmin4 fails to start thereafter.

pgAdmin 4 commit: Add a copyright update tool.

Add a copyright update tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36db047071640678459bfc56ac6946d8fe5e8116 Author: Murtuza Zabuawala Modified Files -- tools/copyright_updater.py | 102 +++

Re: [pgAdmin 4][Patch]: RM 3559 - Far too many mouse clicks to drill down in Browser

Hi On Tue, Dec 18, 2018 at 9:46 AM Khushboo Vashi wrote: > > Hi, > > Please find the attached patch to fix the issue reported in RM #3559 (Far too > many mouse clicks to drill down in Browser) related to Tree Save State. > This RM was updated by the user with the issues in the browser tree state

Re: [pgAdmin4][RM3726] EXCLUDE constraint omits WHERE clause

Thanks, patch applied. On Wed, Dec 19, 2018 at 12:19 PM Aditya Toshniwal wrote: > > Hi Hackers, > > The table definition change was missing in the last patch. Attached is the > part2 for RM3726 which will fix the table definition also. > > Kindly review. > > On Tue, Dec 18, 2018 at 7:07 PM Dave P

pgAdmin 4 commit: Ensure table definitions include WHERE clauses on EXC

Ensure table definitions include WHERE clauses on EXCLUDE constraints. Fixes #3726 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ffae65bdbe403d84204bc1b1f9ed348166324c44 Author: Aditya Toshniwal Modified Files -- .../schemas/ta

Re: [pgAdmin4][Patch]: RM 3796 - Grant Wizard: Text should be "Please add privileges..." instead of "Please select privileges..

Thanks, applied along with some additional tweaks. On Wed, Dec 19, 2018 at 9:30 AM Khushboo Vashi wrote: > > Hi, > > Please find the attached minor patch to fix #3796 - Grant Wizard: Text should > be "Please add privileges..." instead of "Please select privileges..." > > Thanks, > Khushboo --

pgAdmin 4 commit: Tweak the wording on the Grant Wizard. Fixes #3796

Tweak the wording on the Grant Wizard. Fixes #3796 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d14fb85fff0b996870bdcfc5ac4c7830b5bc7c26 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_3_7.rst

pgAdmin 4 commit: Ensure identifiers are properly displayed in the plan

Ensure identifiers are properly displayed in the plan viewer. Fixes #3821 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=13dbfff11d765a20623768f2013b1d6322fe1a10 Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_note

Re: [pgAdmin4] [RM#3824] Make bootstrap tabs visible on dashboard

Thanks, applied. On Tue, Dec 18, 2018 at 2:34 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please ignore my previous patch. > > Here is an updated patch which includes tab hover CSS changes as well. > > > On Tue, Dec 18, 2018 at 7:46 PM Murtuza Zabuawala < > mu

pgAdmin 4 commit: Ensure the dashboard tabs are styles correctly. Fixes

Ensure the dashboard tabs are styles correctly. Fixes #3824 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed01dbd0efecb16076ec3f33397a13bda990b29f Author: Murtuza Zabuawala Modified Files -- .../dashboard/templates/dashboard/dat

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

Hi When testing with quoting set to None, quote = " and delimiter = , I get the following exception when I try to download: 2018-12-20 09:34:02,547: SQL pgadmin: Execute (with server cursor) for server #2 - CONN:354106 (Query-id: 4121147): SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar

pgAdmin 4 commit: Python 2.6 support is officially deprecated.

Python 2.6 support is officially deprecated. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb880678ccdd90ea31b9d874c82bd240164d8aa0 Modified Files -- README | 4 ++-- pkg/mac/README.txt | 2 +- pkg/pip/setup_pip.py