Re: [pgAdmin4] [RM#3824] Make bootstrap tabs visible on dashboard

2018-12-18 Thread Murtuza Zabuawala
Hi Dave, Please ignore my previous patch. Here is an updated patch which includes tab hover CSS changes as well. On Tue, Dec 18, 2018 at 7:46 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Here is updated patch, Please review. > > -- > Regards, > Murtuza Zabua

Re: [pgAdmin4] [RM#3824] Make bootstrap tabs visible on dashboard

2018-12-18 Thread Murtuza Zabuawala
Hi Dave, Here is updated patch, Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Dec 18, 2018 at 3:30 PM Dave Page wrote: > Hi > > On Mon, Dec 17, 2018 at 11:38 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterpri

Re: [pgAdmin4][RM3726] EXCLUDE constraint omits WHERE clause

2018-12-18 Thread Dave Page
Thanks, applied. On Mon, Dec 17, 2018 at 11:59 AM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is the patch to fix the issue where EXLUDE constraint SQL missed the > WHERE clause. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Softwar

pgAdmin 4 commit: Include the WHERE clause on EXCLUDE constraints in RE

2018-12-18 Thread Dave Page
Include the WHERE clause on EXCLUDE constraints in RE-SQL. Fixes #3726 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c973c3387e1ff6a2927106f563104ec11d7c15c6 Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_7.rs

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-18 Thread Akshay Joshi
Hi Dave Attached is the modified patch to fix review comments. On Tue, Dec 18, 2018 at 3:00 PM Akshay Joshi wrote: > > > On Tue, Dec 18, 2018 at 2:49 PM Dave Page wrote: > >> Hi >> >> On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>>

Re: [pgAdmin4] [RM#3824] Make bootstrap tabs visible on dashboard

2018-12-18 Thread Dave Page
Hi On Mon, Dec 17, 2018 at 11:38 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch which will make the bootstrap tabs visible when active and also > when the user hovers on them. > It does what it says, but the styling doesn't match the rest of the tabs in the

Re: [pgAdmin4][Patch] - RM 3823 - Delete/Drop and drop cascade option under properties section is disabled for multiple objects.

2018-12-18 Thread Dave Page
Thank, applied. On Mon, Dec 17, 2018 at 9:46 AM Khushboo Vashi wrote: > > Hi, > > Please find the attached minor patch to fix the issue #3823 - Delete/Drop and > drop cascade option under properties section is disabled for multiple objects. > > Thanks, > Khushboo -- Dave Page Blog: http://pgs

[pgAdmin 4][Patch]: RM 3559 - Far too many mouse clicks to drill down in Browser

2018-12-18 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the issue reported in RM #3559 (Far too many mouse clicks to drill down in Browser) related to Tree Save State. This RM was updated by the user with the issues in the browser tree state save functionality with the reproduction steps. These issues have been

pgAdmin 4 commit: Fix drop/drop cascade regression. Fixes #3823

2018-12-18 Thread Dave Page
Fix drop/drop cascade regression. Fixes #3823 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=72ba5bdaeee8ab6aff8a1496c70f629bae320c55 Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/static/js/collection.js | 10 ++---

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-18 Thread Akshay Joshi
On Tue, Dec 18, 2018 at 2:49 PM Dave Page wrote: > Hi > > On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #3780 pgAdmin4 lacks ability to specify >> NULL values in CSV export. >> >> Please review it. >>

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-18 Thread Dave Page
Hi On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #3780 pgAdmin4 lacks ability to specify > NULL values in CSV export. > > Please review it. > A few points; - You've included code from backports.csv, but per the licence you need to include