Re: [pgAdmin4][Patch]: RM #3734 "Error Message displayed once user use debugger and execute procedure list_emp 5 times with fast speed"

2018-11-20 Thread Dave Page
Thanks, committed. I included a note in the commit message and the code to look for a more appropriate solution in the future. On Tue, Nov 20, 2018 at 8:59 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #3734 "Error Message displayed once user > use debugger and execute

pgAdmin 4 commit: Prevent the debugger controls being pressed again bef

2018-11-20 Thread Dave Page
Prevent the debugger controls being pressed again before previous processing is complete. Fixes #3734 Note that this needs to be re-visited in the future, as the current fix is somewhat hacky. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=

Re: [pgAdmin4][Patch]: RM #3742 ALTER COLUMN bug

2018-11-20 Thread Dave Page
Thanks, patch applied. On Mon, Nov 19, 2018 at 11:44 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3742 "ALTER COLUMN bug". Please > review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > --

pgAdmin 4 commit: Fix changes to the NOT NULL and default value options

2018-11-20 Thread Dave Page
Fix changes to the NOT NULL and default value options in the Table Dialogue. Fixes #3742 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b5abdfa8f996773fd5819ccaf92941503089a2d Author: Akshay Joshi Modified Files -- docs/en_US/r

Re: [pgAdmin4][Patch]: RM #3736 In case of Debugger, if click on breakpoints then other buttons should not disabled

2018-11-20 Thread Dave Page
Thanks, applied. On Fri, Nov 16, 2018 at 7:26 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3736 "In case of Debugger, if click > on breakpoints then other buttons should not disabled". Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > >

pgAdmin 4 commit: Fix toggle breakpoints buttons in the debugger. Fixes

2018-11-20 Thread Dave Page
Fix toggle breakpoints buttons in the debugger. Fixes #3736 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=782b7419f68f5da4a25aa3a06f02c07f782d1cb0 Modified Files -- docs/en_US/release_notes_3_6.rst | 1 + web/pgadmin

Re: [pgAdmin4][Patch]: RM #3354 Debugger does not start if function has input vars of type array

2018-11-20 Thread Dave Page
Hi On Fri, Nov 16, 2018 at 6:53 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3354 "Debugger does not start if > function has input vars of type array". Apart from that patch contains fix > for the following: > >- Parameter values showing twice in case of arra

Re: Import/export servers

2018-11-20 Thread Dave Page
Hi On Tue, Nov 20, 2018 at 6:01 AM Akshay Joshi wrote: > Hi Dave > On Mon, Nov 19, 2018 at 8:09 PM Dave Page wrote: > >> A number of people have asked for the ability to import and export server >> definitions. It's also convenient to have such a feature in the container >> world, where new ins

Re: Import/export servers

2018-11-20 Thread Dave Page
Done - thanks! On Tue, Nov 20, 2018 at 5:34 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > ignore previous, use self.assertEqual(a,b) instead of self.assertTrue(a == > b) > > On Tue, Nov 20, 2018 at 10:46 AM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> small feed

[pgAdmin4][Patch]: RM #3734 "Error Message displayed once user use debugger and execute procedure list_emp 5 times with fast speed"

2018-11-20 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3734 "Error Message displayed once user use debugger and execute procedure list_emp 5 times with fast speed". *Solution*: I have wrapped the logic to enable "*Continue*" button in setTimeout() function with the sleep of 500ms. This is not the exact sol