Re: [pgAdmin4][Patch]: Code refactoring

2018-10-04 Thread Murtuza Zabuawala
+++ Below are the changes, - Move the duplicate code for closing the background process dialog into 'test_gui_helper.py', - Simplify the logic by removing the duplicate steps to insert/update binary paths for each server type from 'test_utils.py'. On Thu, Oct 4, 2018 at 9:35 PM Murtuza Zabuawala

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-04 Thread Khushboo Vashi
Hi Dave, I found one issue with the selecting previous selected node which I was fixed and attached the updated patch. Please let me know if you find any specific scenario which is not covered. While testing the patch, please clear your sqlite entry from the setting table as we have changed the s

[pgAdmin4][Patch]: Code refactoring

2018-10-04 Thread Murtuza Zabuawala
Hi, PFA patch with some code refactoring. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company code_refactoring.diff Description: Binary data

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-04 Thread Khushboo Vashi
On Thu, Oct 4, 2018 at 7:52 PM Dave Page wrote: > Hi > > On Thu, Oct 4, 2018 at 1:12 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> > > This seems to behave quite strangely - only sporadically saving the > treeview state, an

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-04 Thread Dave Page
Hi On Thu, Oct 4, 2018 at 1:12 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > This seems to behave quite strangely - only sporadically saving the treeview state, and then not always (maybe ever?) restoring the selected node. When I

pgAdmin 4 commit: Tag REL-3_4 has been created.

2018-10-04 Thread Akshay Joshi
Tag REL-3_4 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-3_4 Log Message --- Tag v3.4

pgAdmin 4 v3.4 released

2018-10-04 Thread Akshay Joshi
The pgAdmin Development Team are pleased to announce pgAdmin 4 version 3.4. This release of pgAdmin 4 includes over 11 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_3_4.html. pgAdmin is the leading Open So

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-10-04 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Mon, Oct 1, 2018 at 7:14 PM Dave Page wrote: > Hi > > On Mon, Oct 1, 2018 at 1:53 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave >> >> >> On Mon, Oct 1, 2018 at 4:02 PM Dave Page wrote: >> >>> >>> >>>

Re: pgAdmin 3.4 candidate builds

2018-10-04 Thread Fahar Abbas
Hi Dave, I have finished one round of *smoke* and *functionality sanity* on *Windows*, *MAC* and *Docker Hub* and no issue reported. Can you please publish *pgAdmin4 3.4* on https://www.pgadmin.org/ website? Kind Regards, On Mon, Oct 1, 2018 at 3:36 PM Dave Page wrote: > $SUBJECT are now ava

Build failed in Jenkins: pgadmin4-master-python27-feature #17

2018-10-04 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix handling of backslashes in the edit grid. Fixes #3551 [Dave Page] Update message catalogs [Dave Page] Bump version number for release. [Dave Page] Updated Japanese