Re: pgAdmin4 v3.2 candidate builds

2018-08-06 Thread Fahar Abbas
Hi! Smoke verification has been completed on Windows and MAC and no issue found. Detail verification is in progress. On Mon, Aug 6, 2018 at 4:51 PM, Akshay Joshi wrote: > Hi All, > > pgAdmin4 v3.2 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2018-08-06%27/

Re: pgAdmin4 v3.2 candidate builds

2018-08-06 Thread Khushboo Vashi
I have tested it on MAC and it is working properly. On Mon, Aug 6, 2018 at 5:21 PM, Akshay Joshi wrote: > Hi All, > > pgAdmin4 v3.2 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2018-08-06%27/. > > Fahar, can you please verify it for release on Thursday. > >

pgAdmin4 v3.2 candidate builds

2018-08-06 Thread Akshay Joshi
Hi All, pgAdmin4 v3.2 candidate builds and source can be found at https://developer.pgadmin.org/builds/2018-08-06%27/. Fahar, can you please verify it for release on Thursday. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Update version and message catalog for release.

2018-08-06 Thread Akshay Joshi
Update version and message catalog for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7479467a5491528b125e17d1a8c7f81925ed2258 Modified Files -- docs/en_US/release_notes_3_2.rst |2 +- runtime/Info.pl

pgAdmin 4 commit: Add support to save and clear SSH Tunnel password. Fi

2018-08-06 Thread Akshay Joshi
Add support to save and clear SSH Tunnel password. Fixes #3511 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c8c5f83dfe198d6119780bb0ad2d1e29a8d02a22 Modified Files -- docs/en_US/clear_saved_passwords.rst | 6 ++ d

Re: [pgAdmin4][Patch]: RM #3511 Passwords not stored for ssh tunnel connections

2018-08-06 Thread Akshay Joshi
Thanks Khushboo, I'll fix those and commit the code. On Mon, Aug 6, 2018 at 3:33 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > The functionality works properly. > > Some minor comments as below: > - Migration file should contain the purpose of the file instead of

pgAdmin 4 commit: pgAdmin4 should work with python 3.7, Fixes #3458

2018-08-06 Thread Akshay Joshi
pgAdmin4 should work with python 3.7, Fixes #3458 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=52fc0846cdd16dd3c780c5d4277d3f71055506e8 Modified Files -- docs/en_US/release_notes_3_2.rst| 1 + web/pgadmin/too

Re: [pgAdmin4][Patch]: RM #3511 Passwords not stored for ssh tunnel connections

2018-08-06 Thread Khushboo Vashi
Hi Akshay, The functionality works properly. Some minor comments as below: - Migration file should contain the purpose of the file instead of empty message string. - Please remove unwanted imports from the migration file. - The success message should be 'The saved password cleared successfully.'

pgAdmin 4 commit: Added version number for URL's to ensure that files a

2018-08-06 Thread Akshay Joshi
Added version number for URL's to ensure that files are only cached on a per-version basis. Fixes #2136. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb8a288f85a8d970c0e607c3d7998ec93de7370b Author: Aditya Toshniwal Modified Files ---

Re: [pgAdmin4][RM2136] Include "?" on all routes that are loaded

2018-08-06 Thread Akshay Joshi
Thanks patch applied. On Thu, Aug 2, 2018 at 1:07 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch and includes changes suggested by Khushboo. > > > On Wed, Aug 1, 2018 at 12:22 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com>