Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query

2018-06-21 Thread Akshay Joshi
On Thu, Jun 21, 2018 at 11:57 PM, Dave Page wrote: > Hi > > On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 21, 2018 at 6:20 AM, Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi < >>> akshay.jo...@ente

pgAdmin 4 commit: Basic platform detection.

2018-06-21 Thread Dave Page
Basic platform detection. Branch -- electron Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b0be80740d49c0827b25648ca40b1b8bcc3bf07 Modified Files -- pkg/setup-linux.sh | 49 +++-- 1 file changed, 35 ins

pgAdmin 4 commit: Basic script for setting up a Linux build host.

2018-06-21 Thread Dave Page
Basic script for setting up a Linux build host. Branch -- electron Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b0fa10f651b18e651701c124f599b22ce4217a2 Modified Files -- pkg/setup-linux.sh | 21 + 1 file changed, 21 insertion

pgAdmin 4 commit: Minor updates to work on Ubuntu 18.04 without root pr

2018-06-21 Thread Dave Page
Minor updates to work on Ubuntu 18.04 without root privileges. Branch -- electron Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6309a9a7b2b64d737b73bee32ff04990d17bf2ff Modified Files -- electron/package.json | 1 - pkg/build-linux.sh| 18 +++

Jenkins build is back to normal : pgadmin4-master-python26 #802

2018-06-21 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-21 Thread Dave Page
Thanks, applied. On Thu, Jun 21, 2018 at 4:51 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA patch to make SQL ASCII related changes compatible with Python 2.6. > Dictionary comprehension is not supported in Python 2.6. > > On Thu, Jun 21, 2018 at 6:27 PM,

pgAdmin 4 commit: Fix Python 2.6 support for SQL_ASCII data in the quer

2018-06-21 Thread Dave Page
Fix Python 2.6 support for SQL_ASCII data in the query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ba0e1a6f307d434356c24fb5c577b1d16826371 Modified Files -- web/pgadmin/utils/driver/psycopg2/connection.py | 17 +-

Build failed in Jenkins: pgadmin4-master-python26 #801

2018-06-21 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Minor fix to handle auto-discovery of servers with no port recorded. [Dave Page] Allow dropping of Procedures in PG 11. Fixes #3423 -- [

pgAdmin 4 commit: Allow dropping of Procedures in PG 11. Fixes #3423

2018-06-21 Thread Dave Page
Allow dropping of Procedures in PG 11. Fixes #3423 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=560e5f225aca42018a22f69d7d179d8af81f929f Author: Akshay Joshi Modified Files -- .../servers/databases/schemas/functions/static/js/p

pgAdmin 4 commit: Minor fix to handle auto-discovery of servers with no

2018-06-21 Thread Dave Page
Minor fix to handle auto-discovery of servers with no port recorded. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83f9d8a5476a75b353579dca32f06c4e4c1ded31 Author: Akshay Joshi Modified Files -- web/pgadmin/__init__.py | 11

Re: [pgadmin4][Patch]: Fixed minor issue in auto discover server when entry is blank in the config file

2018-06-21 Thread Dave Page
Thanks, applied. On Thu, Jun 21, 2018 at 8:32 AM, Akshay Joshi wrote: > Hi Hackers, > > I have found one minor issue in auto discovery logic. *getint* function > of ConfigParser throws exception if the value of the parameter is blank > in the config file. Example: *Port=* > > Because of that exc

Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query

2018-06-21 Thread Dave Page
Hi On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi wrote: > > > On Thu, Jun 21, 2018 at 6:20 AM, Dave Page wrote: > >> Hi >> >> On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for Feature #3273 Add ability t

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-21 Thread Aditya Toshniwal
Hi Hackers, PFA patch to make SQL ASCII related changes compatible with Python 2.6. Dictionary comprehension is not supported in Python 2.6. On Thu, Jun 21, 2018 at 6:27 PM, Dave Page wrote: > Thanks - patch applied! > > On Wed, Jun 20, 2018 at 3:17 PM, Aditya Toshniwal enterprisedb.com> wrote

Build failed in Jenkins: pgadmin4-master-python26 #800

2018-06-21 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update release notes. [akshay.joshi] Fixed issue of detection of EPAS server 11 and above. Version string is -- [...truncated 7.34 KB..

Build failed in Jenkins: pgadmin4-master-python26 #799

2018-06-21 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix handling of SQL_ASCII data in the query tool. Fixes #3289. Fixes -- [...truncated 7.04 KB...] Cache entry deserialization failed, e

pgAdmin 4 commit: Fixed issue of detection of EPAS server 11 and above.

2018-06-21 Thread Akshay Joshi
Fixed issue of detection of EPAS server 11 and above. Version string is changed in EPAS 11 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=480fe6b9fccffe34f1e28ba0f1ffb4b557d6d8fa Modified Files -- web/pgadmin/browser/server_group

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-21 Thread Dave Page
Thanks - patch applied! On Wed, Jun 20, 2018 at 3:17 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > Attached is the updated patch. (Playing with encodings is not at all fun > :( ) > > On Tue, Jun 19, 2018 at 2:23 AM, Dave Page wrote: > >> Hi >> >> On Mon, Jun 18,

pgAdmin 4 commit: Update release notes.

2018-06-21 Thread Dave Page
Update release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8480c10c74492bcef7a3f8a7cfdfe483591c3319 Modified Files -- docs/en_US/release_notes_3_1.rst | 2 ++ 1 file changed, 2 insertions(+)

pgAdmin 4 commit: Fix handling of SQL_ASCII data in the query tool. Fix

2018-06-21 Thread Dave Page
Fix handling of SQL_ASCII data in the query tool. Fixes #3289. Fixes #3250 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df85392bbf2203e8d4b0796dd449f8a29cf30618 Author: Aditya Toshniwal Modified Files -- web/pgadmin/tools/sqled

[pgadmin4][Patch]: RM #3423 Drop option is not available for the procedure

2018-06-21 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3423 Drop option is not available for the procedure. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3423.patch Description: Binary data

[pgadmin4][Patch]: Fixed minor issue in auto discover server when entry is blank in the config file

2018-06-21 Thread Akshay Joshi
Hi Hackers, I have found one minor issue in auto discovery logic. *getint* function of ConfigParser throws exception if the value of the parameter is blank in the config file. Example: *Port=* Because of that exception pgAdmin4 unable to discover all the valid servers. Attached is the patch to fi