Re: [pgadmin4][Patch]: Test cases for the backup module

2018-06-01 Thread Dave Page
Hi This looks good, except that it's leaving the test_restore_database behind. Can we clean that up please? Thanks. On Fri, Jun 1, 2018 at 7:06 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Victoria, > > Thanks for reviewing the patch. > The tests were failing due to the lat

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-06-01 Thread Victoria Henry
Hey Ashesh, LGTM! The some of the CI tests failed but it looks like a flake. But you can go ahead and merge this. Sincerely, Victoria On Fri, Jun 1, 2018 at 2:36 PM Ashesh Vashi wrote: > On Fri, Jun 1, 2018 at 10:09 PM, Victoria Henry wrote: > >> Hi Ashesh, >> >> We just attempted to apply

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-06-01 Thread Victoria Henry
Hi Ashesh, We just attempted to apply your patch over master but it did not work. We don't want to introduce any bugs or break any functionality. Please update the patch to make sure it is synced up with the master branch. Sincerely, Victoria On Fri, Jun 1, 2018 at 11:18 AM Anthony Emengo wr

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-06-01 Thread Anthony Emengo
Hey Ashesh, Thanks for the explanation. It was great and it really helped! C pgadmin/browser/server_groups/servers/databases/schemas/static/js/child.js C pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema_child_tree_node.js It makes sense to remove duplication by extractin

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-06-01 Thread Ashesh Vashi
On Thu, May 24, 2018 at 8:13 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hey, Thanks so much for the reply. > > We've noticed that you've made several modifications on top of our > original patch. Unfortunately, we've found it very hard to follow. Could we > please get a b