Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

Hello Victoria & Joao, On Thu, May 31, 2018 at 2:17 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > > We are having a hard time understanding the logic on the change. > > If tunnel_authentication is not on the model and the tunnel_identify_file > is present, we

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Victoria/Joao, On Thu, May 31, 2018 at 2:06 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Aditya, > > It looks ok and it passes CI. > > We have some recommendations: > - These look like 2 different changes so they should be in separated > commits > If you are talk

Re: [PATCH] Support for the source-map in Karma test framework

Thanks, applied. On Wed, May 30, 2018 at 3:50 AM, Ashesh Vashi wrote: > Hi Team, > > Debugging the failed jasmine test-cases is very difficult with the current > implementation. > The stack-traces does not give the correct information as It does not > have source-map support for the original cod

pgAdmin 4 commit: Add support for source maps in the karma test framewo

Add support for source maps in the karma test framework to aid debugging. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86712b1bd2df25525cce923a382963797a1c6e25 Author: Ashesh Vashi Modified Files -- web/karma.conf.js |

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Thanks all, applied. On Wed, May 30, 2018 at 5:06 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Akshay, > > Thanks for taking a look. We did the following changes over your patch: > >- Changed the XPATH to CSS_SELECTOR, please look in >pgadmin/feature_tests/qu

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Thanks, applied. On Wed, May 30, 2018 at 1:52 AM, Akshay Joshi wrote: > Hi Joao > > On Tue, May 29, 2018 at 9:10 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Akshay, >> >> The code looks good, we do have some minor notes for next time: >> >> . To make the code

pgAdmin 4 commit: Add support for LISTEN/NOTIFY in the query tool. Fixe

Add support for LISTEN/NOTIFY in the query tool. Fixes #3204 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38ee39ae7acb32e331f0ba291e1036d721de8eb4 Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_1.rst

Re: [pgAdmin4][Patch] RM #3355 User can not perform operation of backup,Backup all, Backup global and Maintenance DB with ssh tunneling

Thanks, applied. On Tue, May 29, 2018 at 6:41 AM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #3355 User can not perform operation of > backup, Backup all, Backup global and Maintenance DB with ssh tunneling. > > Please review it. > > -- > *Akshay Joshi* > > *Sr. Softwa

pgAdmin 4 commit: Ensure backup/restore/maintenance work via SSH tunnel

Ensure backup/restore/maintenance work via SSH tunnels. Fixes #3355 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b4605a9d390cb44e5dfe9967c3adf2b28d04f1f Author: Akshay Joshi Modified Files -- web/pgadmin/tools/backup/__init__.

Re: pgadmin, docker and ipv6

Thanks! On Wed, May 30, 2018 at 5:53 PM, Александр Шишенко wrote: > Sure, here is the ticket: https://redmine.postgresql.org/issues/3392 > > 31.05.2018, 00:47, "Dave Page" : > > Hi > > On Sun, May 27, 2018 at 7:13 AM, Александр Шишенко > wrote: > > Hello, > > I was running my pgadmin4 v2 on my

Re: pgadmin, docker and ipv6

Sure, here is the ticket: https://redmine.postgresql.org/issues/3392 31.05.2018, 00:47, "Dave Page" :Hi On Sun, May 27, 2018 at 7:13 AM, Александр Шишенко wrote:Hello, I was running my pgadmin4 v2 on my ipv6-only subnet using docker image. After the update, I noticed, that you

Re: pgadmin, docker and ipv6

Hi On Sun, May 27, 2018 at 7:13 AM, Александр Шишенко wrote: > Hello, > > I was running my pgadmin4 v2 on my ipv6-only subnet using docker image. > After the update, I noticed, that you have changed your webserver from > Apache to gunicorn, and it is configured to listen only on ipv4 network > (

Re: Container build hanging

Hi So it turns out the hang was a result of: = Using the '.eslintignore' config file for excluding the temporary, vendor specific, and templates files, instead of writing our own logic to do so. Patch by: Anthony & Joao Reviewed by: Khushboo Branch -- master Details --- https://git

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hello Akshay, Thanks for taking a look. We did the following changes over your patch: - Changed the XPATH to CSS_SELECTOR, please look in pgadmin/feature_tests/query_tool_tests.py:660 and 667 - Changed the other places in _query_tool_notify_statements to do not use xpath. - Moved t

Re: pgAdmin 4 commit: Disable emojis in Yarn output.

Yeah - I pushed by mistake (don't ask). It's reverted now. Sorry! On Wed, May 30, 2018 at 4:50 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Dave, > When running yarn linter after this commit we get the following: > > yarn run v1.7.0 > $ yarn eslint --emoji false --n

pgAdmin 4 commit: Remove duplicate options

Remove duplicate options Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8bda4e02305d2d9481de5fbc1d0fe225b8cb9405 Modified Files -- pkg/docker/Dockerfile | 2 +- web/package.json | 12 ++-- 2 files changed, 7 insertions

pgAdmin 4 commit: Fix failed yarn changes

Fix failed yarn changes Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b00931407ee2cd3588a3ed81b94c464cd95c379f Modified Files -- pkg/docker/Dockerfile | 4 ++-- web/package.json | 20 ++-- 2 files changed, 12

pgAdmin 4 commit: Revert failed Yarn changes.

Revert failed Yarn changes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a28b9ff26b7cde442dd2aaeed72d5c3b47fc30f Modified Files -- pkg/docker/Dockerfile | 2 +- web/package.json | 12 ++-- 2 files changed, 7 inserti

pgAdmin 4 commit: Fix failed yarn changes

Fix failed yarn changes Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bea176a6463690a3e2cecda37569125cf97e575c Modified Files -- pkg/docker/Dockerfile | 2 +- web/package.json | 18 +- 2 files changed, 10 inse

Re: pgAdmin 4 commit: Disable emojis in Yarn output.

Hello Dave, When running yarn linter after this commit we get the following: yarn run v1.7.0 $ yarn eslint --emoji false --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx . $ /Users/pivotal/workspace/pgadmin4/web/node_modules/.bin/eslint --emoji false --no-eslintrc -c .eslintrc.js --ext .js --ext

Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

Hi Murtuza, We are having a hard time understanding the logic on the change. If tunnel_authentication is not on the model and the tunnel_identify_file is present, we change the tunnel_identify_file in the model to null? Is this what you mean? Thanks Victoria && Joao ​ On Wed, May 30, 2018 at 9:

pgAdmin 4 commit: Disable emojis in Yarn output.

Disable emojis in Yarn output. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b2d4c6ef9d7715c62310bd05dace97f7523a527d Modified Files -- pkg/docker/Dockerfile | 4 ++-- web/package.json | 20 ++-- 2 files chang

pgAdmin 4 commit: Fix syntax

Fix syntax Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=189e3076719be3bf592e2b9ae766c9377ef24668 Modified Files -- pkg/docker/Dockerfile | 2 +- web/package.json | 18 +- 2 files changed, 10 insertions(+), 10

Re: [PATCH] Support for the source-map in Karma test framework

Hello Ashesh The change looks great. This will help the community a lot when we are TDDing new features. Please do not forget NOT to commit the second patch. Thanks Victoria && Joao On Wed, May 30, 2018 at 3:51 AM Ashesh Vashi wrote: > Hi Team, > > Debugging the failed jasmine test-cases is v

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hello Aditya, It looks ok and it passes CI. We have some recommendations: - These look like 2 different changes so they should be in separated commits - Do we have test coverage for the bug that you are talking about? If not we should, to ensure this problem does not happen again in a future chan

Container build hanging

Hi The container build is hanging for me on 2 different machines at: 20:19:50 $ cross-env NODE_ENV=production yarn run bundle:dev 20:19:51 $ yarn run linter && yarn run webpacker 20:19:52 $ yarn eslint --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx . 20:19:52 $ /pgadmin4/web/node_modules/.bin

[pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

Hi, PFA minor patch to fix the issue when you change any field in server dialog 'tunnel_identity_file' model value get included unnecessarily in the update request. eg: Change the server name and click on Save button, Check the request payload in network console. -- Regards, Murtuza Zabuawala En

[PATCH] Support for the source-map in Karma test framework

Hi Team, Debugging the failed jasmine test-cases is very difficult with the current implementation. The stack-traces does not give the correct information as It does not have source-map support for the original code. And, that makes it very difficult to debug the issue during development. Please

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, PFA updated patch after all the permutations, combinations for encoding for SQL_ASCII database. Also fixed a small glitch for sql editor connection status check. Please note, ERROR: invalid byte sequence for encoding "UTF8": 0xe9 0x73 is a Postgres DB error and not pgAdmin4 error.