Hi Anthony/Joao,
That worked well !! Nice !! ( I am very new to Jasmine tests :P. Need to
dig in. )
Hackers,
Kindly review the patch attached in the trailing mail for RM#3271
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Hea
>
> Hi Dave,
>
> Thank you very much for your feedback.
>
> That's a good idea to see individual images. But in my opinion, for
> geometry data, user often tend to see not only the individual shapes, but
> also the locations, spatial relations and distribution in a map. For
> example, if the geomet
As part of the development environment we do not see the reasoning behind
not add PYTHONPATH to the environment variables, specially because this
looks like the way pytest was invisoned.
However please try the following patch instead. We've changed the pytest
invocation to assume the relevant dir
Hello Aditya,
We changed the way the tests were running and we could remove the function.
Instead of piggybackiung on a deprecated field we created a html fixture
$('body').append(
'' +
'' +
'' +
''
);
With it we could use the real JQuery instead of mocking it.
Now the tests look like t
On Thu, May 24, 2018 at 5:14 PM, Anthony Emengo wrote:
> Here’s a followup patch with the relevant README and Makefile changes. To
> be clear, both patches need to be applied in succession to run the tests.
>
> The error that you were running into was because the appropriate
> PYTHONPATH environm
Here’s a followup patch with the relevant README and Makefile changes. To
be clear, both patches need to be applied in succession to run the tests.
The error that you were running into was because the appropriate PYTHONPATH
environment variable was not set. We updated the README to reflect that,
b
Hey, Thanks so much for the reply.
We've noticed that you've made several modifications on top of our original
patch. Unfortunately, we've found it very hard to follow. Could we please
get a brief synopsis of the changes you have made - just so we can better
understand the rationale behind them? J
Hi
On Wed, May 23, 2018 at 10:48 PM, Anthony Emengo wrote:
> Hey all,
>
> Attached is a rather large patch that attempts to introduce the Pytest
> test runner and Grappah test matcher into our code base. The patch replaces
> all of the previous python unit tests from the previous design. This is
Hi
On Wed, May 23, 2018 at 1:23 PM, Xuri Gong wrote:
> Hi Dave/Team,
>
> My name is Xuri Gong. I am working on implementing geospatial data viewer
> in pgAdmin4.
>
> I wrote a design document for the viewer[1] according to the related
> issue[2] and I am wondering if it is a proper design. It wo
Hi Joao,
Thank you very much for these detailed guidelines.
I will follow these standards and test both JavaScript and Python code
before sending a patch. For the new panel, I am learning React these days
and will spend three months implementing this viewer so I think I can do
it.
Thanks.
>
10 matches
Mail list logo
