Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Thank you Victoria, Anthony. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Tue, May 22, 2018 at 7:15 PM, Victoria Henry wrote: > Hi Aditya, > > We made a minor change to make the patch so the python l

Re: GSoC Introduction - Implement geospatial data viewer in pgAdmin4 for PostGIS

Xuri, This is a fabulous idea and congratulations on being selected for GSoC! Personally, I would find this functionality very helpful. Have you received any feedback, and are you still looking for more? Also, if you have not already, I would highly recommend you coordinate with Dave Page and hi

pgAdmin 4 commit: Add some more missing CALL statements

Add some more missing CALL statements Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fa57c02d0ebefc07e3c6918386fc479fc89ac3e5 Modified Files -- Make.bat | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

pgAdmin 4 commit: CALL all external programs, or labels cannot be found

CALL all external programs, or labels cannot be found. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83bee60fa45d1c38a4ff0e5370ef7ab1b7ed03be Modified Files -- Make.bat | 16 1 file changed, 8 insertions(+), 8 del

pgAdmin 4 commit: Minor fixes

Minor fixes Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=81a5e1ffd3fef2790ebd62016ae06736827a66a3 Modified Files -- Make.bat | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Aditya, We made a minor change to make the patch so the python linter can pass. Attached is the change we made. Everything else looks good. Sincerely, Victoria & Anthony On Tue, May 22, 2018 at 4:46 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > PFA updated patch.

pgAdmin 4 commit: Handle dependencies that may or may not be present.

Handle dependencies that may or may not be present. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b5912b09c0697329885dcca889a10b7f10099fc Modified Files -- Make.bat | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions

pgAdmin 4 commit: There's no need to activate/deactivate/activate the v

There's no need to activate/deactivate/activate the venv. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=578071903532af816bde97c4ae5e1c5dab28c5a7 Modified Files -- Make.bat | 9 + 1 file changed, 1 insertion(+), 8 deletions

pgAdmin 4 commit: Returning %ERRORLEVEL% is proving unreliable. Just re

Returning %ERRORLEVEL% is proving unreliable. Just return 1 instead if there's an error. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0f530e824d4908b41204e1a71104714e5bb32aa Modified Files -- Make.bat | 108 +++

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

On Tue, May 22, 2018 at 10:01 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Tue, May 22, 2018 at 2:02 PM, Dave Page wrote: > >> >> >> On Tue, May 22, 2018 at 9:13 AM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi < >>> akshay.jo...@e

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Dave On Tue, May 22, 2018 at 2:02 PM, Dave Page wrote: > > > On Tue, May 22, 2018 at 9:13 AM, Dave Page wrote: > >> Hi >> >> On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> As per suggestion by Dave, I have modified the logi

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi, PFA updated patch. Linter issues are fixed ( we dont have any linter setup for python :-( ) Regarding test cases, they run successfully on my system and the reason it failed for pivotal is timeout exception. I am sorry I can't help with that. Traceback (most recent call last): File "/tmp/bu

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

On Tue, May 22, 2018 at 9:13 AM, Dave Page wrote: > Hi > > On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> As per suggestion by Dave, I have modified the logic and now >> notifications are popped up in alertify dialog(refer Notify_Mes

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi wrote: > Hi Hackers, > > As per suggestion by Dave, I have modified the logic and now notifications > are popped up in alertify dialog(refer Notify_Messages.png) as and when > received on that session where "LISTEN" is executed. Attached is the >

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Pivotal's buildbot is showing problems with this patch: https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-linter/builds/66 (linter failed) https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/84 (tests failed) On T

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi All Please ignore the previous patch. Attached is the latest one. On Tue, May 22, 2018 at 11:37 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > As per suggestion by Dave, I have modified the logic and now notifications > are popped up in alertify dialog(refer Notify