Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-21 Thread Akshay Joshi
Hi Hackers, As per suggestion by Dave, I have modified the logic and now notifications are popped up in alertify dialog(refer Notify_Messages.png) as and when received on that session where "LISTEN" is executed. Attached is the modified patch, please review it. To test this feature following step

[pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-05-21 Thread Aditya Toshniwal
Hi Hackers, PFA patch for RM#3289 where decode error was thrown on querying a SQL_ASCII database table. Please note, this problem occurs only on windows. Sample insert - insert into test_tab values ('é'); psycopg2 has a encodings dictionary where Postgres Database Encodings are mapped to python e

pgAdmin 4 commit: Need to CALL Yarn.

2018-05-21 Thread Dave Page
Need to CALL Yarn. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0bf89f3dc0d8093cc9422c72c3e175ec59c5b80d Modified Files -- Make.bat | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Further windows make script cleanup.

2018-05-21 Thread Dave Page
Further windows make script cleanup. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5e48ecdc2afe0a92c5a37ababd1caf1df920b73 Modified Files -- Make.bat | 17 - 1 file changed, 8 insertions(+), 9 deletions(-)

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-05-21 Thread Dave Page
Ashesh, please prioritise this so we can move on. Thanks. On Mon, May 21, 2018 at 2:46 PM, Anthony Emengo wrote: > Hey all, > > We haven't heard from you all in a while regarding our last statements. Is > there any thing that I need to clarify? We feel left in the dark here and > just want to k

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-05-21 Thread Anthony Emengo
Hey all, We haven't heard from you all in a while regarding our last statements. Is there any thing that I need to clarify? We feel left in the dark here and just want to know what we can do help. Cheers! Anthony && Joao

pgAdmin 4 commit: Don't barf on nested parentheses as we may find on 64

2018-05-21 Thread Dave Page
Don't barf on nested parentheses as we may find on 64 bit systems. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=066a59d89c068ee52d479187a35374c7c4f6576e Modified Files -- Make.bat | 16 1 file changed, 8 insertio

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-21 Thread Akshay Joshi
Hi Dave On Fri, May 18, 2018 at 4:56 PM, Dave Page wrote: > > > On Fri, May 18, 2018 at 12:11 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, May 18, 2018 at 3:58 PM, Dave Page wrote: >> >>> Hi >>> >>> On Wed, May 16, 2018 at 2:51 PM, Anthony Emengo >>> wr