pgAdmin 4 commit: Major cleanup of the Windows installer build script.

2018-05-18 Thread Dave Page
Major cleanup of the Windows installer build script. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e1a3caa780ca8c679fd3ed553b2f3d9fa09c5e75 Modified Files -- Make.bat | 426 +++-

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-18 Thread Dave Page
On Fri, May 18, 2018 at 12:11 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Fri, May 18, 2018 at 3:58 PM, Dave Page wrote: > >> Hi >> >> On Wed, May 16, 2018 at 2:51 PM, Anthony Emengo >> wrote: >> >>> Hey, >>> >>> The code looks great! The tests all passed as well. >

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-18 Thread Akshay Joshi
Hi Dave On Fri, May 18, 2018 at 3:58 PM, Dave Page wrote: > Hi > > On Wed, May 16, 2018 at 2:51 PM, Anthony Emengo > wrote: > >> Hey, >> >> The code looks great! The tests all passed as well. >> > > Agreed - however, unless you check the Messages panel, you're not likely > to see that a message

Re: [pgAdmin4][Patch]: Fixed RM #3295 - Shortcut key conflict issue

2018-05-18 Thread Dave Page
Thanks - patch applied! On Fri, May 18, 2018 at 7:15 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Just to add, the previous patch was not working because, firefox does not > focus a div element if it does not have tabindex(value greater than -1) > attribute (

pgAdmin 4 commit: Ensure the debugger container has focus when loaded.

2018-05-18 Thread Dave Page
Ensure the debugger container has focus when loaded. Fixes #3295 - this time on Firefox too! Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6492dacbb2c83b072ef567de4569d529aebfc6f0 Author: Aditya Toshniwal Modified Files -- web/

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-18 Thread Dave Page
Hi On Wed, May 16, 2018 at 2:51 PM, Anthony Emengo wrote: > Hey, > > The code looks great! The tests all passed as well. > Agreed - however, unless you check the Messages panel, you're not likely to see that a message was received. Can we also show each message in an alertify panel? -- Dave

Re: [pgAdmin4][RM#3307]User interface unable to connect to database running on port range 1-1024

2018-05-18 Thread Dave Page
Thanks, applied. On Wed, May 16, 2018 at 2:34 PM, Victoria Henry wrote: > Hi Aditya, > > Looks good to us! > > Sincerely, > > Anthony & Victoria > > > On Wed, May 16, 2018 at 7:24 AM Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA patch to allow server port number below 102

pgAdmin 4 commit: Allow connections to servers with port numbers < 1024

2018-05-18 Thread Dave Page
Allow connections to servers with port numbers < 1024 which may be seen in container environments. Fixes #3307 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4ed9d69768e6b68822774cf26d26d7dc9b4f4ab Author: Aditya Toshniwal Modified Files -

Jenkins build is back to normal : pgadmin4-master-python27 #620

2018-05-18 Thread pgAdmin 4 Jenkins
See