Jenkins build is back to normal : pgadmin4-master-python35 #617

2018-05-17 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python36 #614

2018-05-17 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python34 #610

2018-05-17 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python33 #621

2018-05-17 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4][Patch]: Fixed RM #3295 - Shortcut key conflict issue

2018-05-17 Thread Aditya Toshniwal
Hi Hackers, Just to add, the previous patch was not working because, firefox does not focus a div element if it does not have tabindex(value greater than -1) attribute (somehow it works in chrome). self.docker.$container referred to div(class-wcDocker) which does not have tabindex attribut. So cha

Jenkins build is back to normal : pgadmin4-master-python26 #753

2018-05-17 Thread pgAdmin 4 Jenkins
See

Build failed in Jenkins: pgadmin4-master-python33 #620

2018-05-17 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Correct the logic to set the SUPPORT_SSH_TUNNEL flag, if the flag is -- [...truncated 334 B...] > git rev-parse --verify HEAD # tim

Build failed in Jenkins: pgadmin4-master-python27 #619

2018-05-17 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Correct the logic to set the SUPPORT_SSH_TUNNEL flag, if the flag is -- [...truncated 749 B...] Commit message: "Correct the logic t

Re: [pgAdmin4][Patch]: Fixed RM #3295 - Shortcut key conflict issue

2018-05-17 Thread Aditya Toshniwal
Hi Hackers, PFA updated patch for RM#3295. The patch is to fix the issue in firefox also. Kindly review. Please try in firefox also. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Wed, May 9, 2018 at 6:

pgAdmin 4 commit: Fixed pep8 issue for last commit.

2018-05-17 Thread Akshay Joshi
Fixed pep8 issue for last commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28126a0a0dd242620df137a88f8b05e78c2c230c Modified Files -- web/config.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Build failed in Jenkins: pgadmin4-master-python35 #616

2018-05-17 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Correct the logic to set the SUPPORT_SSH_TUNNEL flag, if the flag is -- [...truncated 23 B...] Building in workspace

Build failed in Jenkins: pgadmin4-master-python36 #613

2018-05-17 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Correct the logic to set the SUPPORT_SSH_TUNNEL flag, if the flag is -- [...truncated 23 B...] Building in workspace

Build failed in Jenkins: pgadmin4-master-python34 #609

2018-05-17 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Correct the logic to set the SUPPORT_SSH_TUNNEL flag, if the flag is -- [...truncated 23 B...] Building in workspace

Build failed in Jenkins: pgadmin4-master-python26 #752

2018-05-17 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Correct the logic to set the SUPPORT_SSH_TUNNEL flag, if the flag is -- [...truncated 4.11 KB...] Ignoring SQLAlchemy: markers 'pyth

pgAdmin 4 commit: Correct the logic to set the SUPPORT_SSH_TUNNEL flag

2018-05-17 Thread Akshay Joshi
Correct the logic to set the SUPPORT_SSH_TUNNEL flag, if the flag is set the False in local config file, then we should not override it. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb0c322ccf80ab9a3ff322af13e1f59e9baa8a82 Modified Files

pgAdmin 4 commit: Fixed issue where 'Identity file' control of SSH Tunn

2018-05-17 Thread Akshay Joshi
Fixed issue where 'Identity file' control of SSH Tunnel tab is enabled when database is connected and 'Use SSH tunneling' flag is set to No. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=719938a14c1b6bdae96aff82a2f6a02901a7ca8d Modified Fil

Re: [pgadmin] Prefer CSS selectors to XPath selectors in feature tests

2018-05-17 Thread Ashesh Vashi
On Wed, May 16, 2018 at 7:26 PM, Anthony Emengo wrote: > Hey all, > > We've noticed that our feature tests make extensive use of xpath with the > selenium api. It's well documented that css selectors are easier to read > and more efficient. I think we should start to favor these if we have not >