Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi Dave On Mon, May 14, 2018 at 6:33 PM, Dave Page wrote: > > > On Mon, May 14, 2018 at 2:03 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On which database server you are running this test cases, I have tested >> it on PG 9.6 >> > > PG 9.4. > I have tested it

[pgAdmin4][Patch]: Minor JS Fix

Hi, Please find the attached monir patch to fix the JS issue. Thanks, Khushboo diff --git a/web/pgadmin/tools/debugger/static/js/direct.js b/web/pgadmin/tools/debugger/static/js/direct.js index b9cb2ec..0326082 100644 --- a/web/pgadmin/tools/debugger/static/js/direct.js +++ b/web/pgadmin/tools/de

Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript

Apologies, here's a redo that should apply cleanly on top of master Anthony && Joao On Mon, May 14, 2018 at 3:25 PM Anthony Emengo wrote: > Hi Hackers, > > Attached you can find a patch that changes the way we are running ESLint > on the Javascript files. Instead of using Javascript we can use

[pgadmin4][patch] Use ESLinter options instead of using Javascript

Hi Hackers, Attached you can find a patch that changes the way we are running ESLint on the Javascript files. Instead of using Javascript we can use ESLint parameters to archive the same goal. In the future this will also allow us to use the rest of the cli parameters like (--fix and others...)

pgAdmin 4 commit: Allow "make" to be overridden in the environment.

Allow "make" to be overridden in the environment. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d9e9eab13a6f0fbedc27356961938b3554b8899 Modified Files -- Make.bat | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Correct error message

Correct error message Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe81ae32853c6d73d38f671b3a347212da3d06cf Modified Files -- Make.bat | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [pgadmin][patch] Fix regression tests failures on Windows

Thanks - applied! On Mon, May 14, 2018 at 3:24 PM, Anthony Emengo wrote: > Hey hackers, > > Attached is a patch that accommodates the recent `os.path` implementation > changes for Windows. The tests were previously working on Unix but not yet > Windows > > Joao && Anthony > -- Dave Page Blog

pgAdmin 4 commit: Fix template handling in tests for Windows.

Fix template handling in tests for Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ab27b9d1180b96300480f503da57309bc64016cd Author: Anthony Emengo Modified Files -- .../tests/test_external_tables_view.py | 35

[pgadmin][patch] Fix regression tests failures on Windows

Hey hackers, Attached is a patch that accommodates the recent `os.path` implementation changes for Windows. The tests were previously working on Unix but not yet Windows Joao && Anthony 0001-Fix-Windows-Tests.patch Description: Binary data

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

On Mon, May 14, 2018 at 2:03 PM, Akshay Joshi wrote: > Hi Dave > > On which database server you are running this test cases, I have tested it > on PG 9.6 > PG 9.4. > > On Mon, May 14, 2018 at 5:45 PM, Dave Page wrote: > >> >> Hi >> >> On Mon, May 14, 2018 at 7:29 AM, Akshay Joshi < >> akshay.

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi Dave On which database server you are running this test cases, I have tested it on PG 9.6 On Mon, May 14, 2018 at 5:45 PM, Dave Page wrote: > > Hi > > On Mon, May 14, 2018 at 7:29 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Anthony >> >> Thanks for updated patch, it is

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Mon, May 14, 2018 at 6:10 PM, Dave Page wrote: > > > On Mon, May 14, 2018 at 1:38 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Mon, May 14, 2018 at 2:59 PM, Dave Page wrote: >> >>> >>> >>> On Sat, May 12, 2018 at 12:10 AM, Ashesh Vashi < >>> ashesh.va...@enterprisedb.com

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Mon, May 14, 2018 at 1:38 PM, Ashesh Vashi wrote: > On Mon, May 14, 2018 at 2:59 PM, Dave Page wrote: > >> >> >> On Sat, May 12, 2018 at 12:10 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Sat, May 12, 2018, 02:58 Joao De Almeida Pereira < >>> jdealmeidapere...@pivotal

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Mon, May 14, 2018 at 2:59 PM, Dave Page wrote: > > > On Sat, May 12, 2018 at 12:10 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Sat, May 12, 2018, 02:58 Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hello Ashesh, >>> >>> 1. In TreeNode, we're ke

pgAdmin 4 commit: Initial version of the new tree implementation.

Initial version of the new tree implementation. This is the first version of our Tree implementation. At this point is a very simple tree without no abstractions and with code that eventually is not very performant, but this is only the first iteration and we are trying to follow the 'Last Respons

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi On Mon, May 14, 2018 at 7:29 AM, Akshay Joshi wrote: > Hi Anthony > > Thanks for updated patch, it is working fine on my machine. I have tested > it couple of times. > > I've tested it a couple of times and still see the pgDataType failure. I've attached the screenshot; I have to wonder why t

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Sat, May 12, 2018 at 12:10 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Sat, May 12, 2018, 02:58 Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Ashesh, >> >> 1. In TreeNode, we're keepging the reference of DOMElement, do we really need it? >>>

Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

Hi Hackers, Please hold on with the patch. Will send the updated patch soon. Apologies. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Mon, May 14, 2018 at 12:52 PM, Aditya Toshniwal < aditya.toshni..

[pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

Hi Hackers, PFA patch for upgrading jQuery version to 3.3.1 from current version 1.12.4. Patch includes replacing deprecated functions of jquery to latest one. Kindly review. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat