Re: [pgAdmin4][RM#3298] Query tool shortcut issue

2018-05-08 Thread Victoria Henry
Hi Aditya, The patch looks fine and the tests are passing. Sincerely, Victoria & Anthony On Tue, May 8, 2018 at 8:22 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA patch for query tool keyboard issue where arrow keys were not behaving > as expected for e

[pgAdmin4][RM#3298] Query tool shortcut issue

2018-05-08 Thread Aditya Toshniwal
Hi Hackers, PFA patch for query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Also, corrected couple of dropdown HTML codes. Request you to kindly review. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions |

pgAdmin 4 commit: Fix ordering of changes in release notes.

2018-05-08 Thread Dave Page
Fix ordering of changes in release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5960644bae81f67fe896970b3ceb70cbab41d02c Modified Files -- docs/en_US/release_notes_3_1.rst | 8 1 file changed, 4 insertions(+), 4 d

pgAdmin 4 commit: Updated release note for 3.1

2018-05-08 Thread Akshay Joshi
Updated release note for 3.1 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=39ea7c2916e699adc9de3e023ed63d64ab331936 Modified Files -- docs/en_US/release_notes_3_1.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [pgAdmin4][Patch]: Fix layout of the error message in the query tool

2018-05-08 Thread Dave Page
Can you update the release notes for that as well please? Thanks. On Mon, May 7, 2018 at 11:35 AM, Akshay Joshi wrote: > Thanks patch applied. > > On Mon, May 7, 2018 at 12:53 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the

pgAdmin 4 commit: Ensure the runtime core application is setup before t

2018-05-08 Thread Dave Page
Ensure the runtime core application is setup before trying to access any settings. Fixes # Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c68848e7f30fed68b58ddf500c5bfe702f75ef48 Modified Files -- docs/en_US/release_notes_3_1

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

2018-05-08 Thread Akshay Joshi
On Tue, 8 May 2018, 13:35 Dave Page, wrote: > Could you update the 3.1 release notes to reflect that please? > Sure > > On Mon, May 7, 2018 at 10:40 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks patch applied. >> >> On Mon, May 7, 2018 at 12:16 PM, Khushboo Vashi <

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

2018-05-08 Thread Dave Page
Could you update the 3.1 release notes to reflect that please? On Mon, May 7, 2018 at 10:40 AM, Akshay Joshi wrote: > Thanks patch applied. > > On Mon, May 7, 2018 at 12:16 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> >>