Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Wed, May 2, 2018 at 6:03 PM, Ashesh Vashi wrote: > On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> I have reviewed your code and looks good to me. Can we change the message >> from "The database name is inappropriate" to some meanin

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi On Wed, May 2, 2018 at 9:05 PM, Victoria Henry wrote: > Hi Akshay, > > Thanks for sending this updated patch. The linter and tests are all > passing. > >> - utils/driver/psycopg2/server_manager.py >>> - Do we have Unit Tests around this? >> >> No. > > > In our opinion, server_manager.py a

Re: [pgAdmin4][RM#3324] - Windows user unable to expand "External Tables" navigation item

Forgive me but please consider the following patch instead - as it better adheres to the python style guide. On Wed, May 2, 2018 at 12:43 PM Anthony Emengo wrote: > Hi Hackers, > > Please find the attached patch to fix the RM #3324 : user cannot load > “External Tables” on the navigation pane. >

[pgAdmin4][RM#3324] - Windows user unable to expand "External Tables" navigation item

Hi Hackers, Please find the attached patch to fix the RM #3324 : user cannot load “External Tables” on the navigation pane. The issue was that ultimately paths were not being cleaned after being munged from the “template” input which would result in template_paths that resembled: path//to//dir.sq

pgAdmin 4 commit: Allow feature tests to run in Chrome headless mode.

Allow feature tests to run in Chrome headless mode. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59d8f6fb84e0aabc098fecf968cde3f9fcdf53b0 Modified Files -- web/regression/feature_utils/app_starter.py | 1 - web/regression/runtest

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi Khushboo, Could you write tests for this change? These files are actually apart of the ACITree refactoring patch. If this patch was already in master the task of adding tests would be much easier. Victoria & Joao On Wed, May 2, 2018 at 8:33 AM, Ashesh Vashi wrote: > On Wed, May 2, 2018 at 5

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi Akshay, Thanks for sending this updated patch. The linter and tests are all passing. > - utils/driver/psycopg2/server_manager.py >> - Do we have Unit Tests around this? > > No. In our opinion, server_manager.py and connection.py should have tests. Are you finding it difficult to add tes

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi wrote: > Hi Khushboo > > I have reviewed your code and looks good to me. Can we change the message > from "The database name is inappropriate" to some meaningful message, so > that user should know why it is inappropriate. If user will be able to > cre

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi Khushboo I have reviewed your code and looks good to me. Can we change the message from "The database name is inappropriate" to some meaningful message, so that user should know why it is inappropriate. If user will be able to create database with "=" in name then why Backup, Maintenance and Re

pgAdmin 4 commit: Python 3 fixes

Python 3 fixes Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0b6fb0e5d0b53218ecdeba228243aed12c2edba Modified Files -- pkg/mac/build.sh | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

[pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi, Please find the attached patch which will fix RMs # 1220 and #1221. If the database name contains = then the backup, maintenance and restore jobs are failing. To fix these, we will display the error message regarding inappropriate database name. Thanks, Khushboo diff --git a/web/pgadmin/tool

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Wed, May 2, 2018 at 6:30 AM, Ashesh Vashi wrote: > On Mon, Apr 30, 2018 at 11:27 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> You've lost us with the last reply. We'd love to know what we'd have to >> do to get this patch committed. You mention that "some things ar