Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

2018-05-01 Thread Akshay Joshi
Thanks patch applied. On Wed, May 2, 2018 at 11:16 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch which fixes the linter issues. > > Thanks, > Khushboo > > On Wed, May 2, 2018 at 11:10 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com

pgAdmin 4 commit: F5 key should work to refresh Browser tree. Fixes #32

2018-05-01 Thread Akshay Joshi
F5 key should work to refresh Browser tree. Fixes #3284 Refactoring by: Joao Pedro De Almeida Pereira Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=732d8d903dc76eef22b83a8eb01ed754ba877f31 Author: Khushboo Vashi Modified Files

Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

2018-05-01 Thread Khushboo Vashi
Hi Akshay, Please find the attached patch which fixes the linter issues. Thanks, Khushboo On Wed, May 2, 2018 at 11:10 AM, Akshay Joshi wrote: > Hi Joao > > Linter fails for 'parse_shortcut_value_spec.js' file: > > $ node pga_eslint.js > > > /Users/akshay/Development/pgadmin4/web/regression/ >

Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

2018-05-01 Thread Akshay Joshi
Hi Joao Linter fails for 'parse_shortcut_value_spec.js' file: $ node pga_eslint.js /Users/akshay/Development/pgadmin4/web/regression/javascript/parse_shortcut_value_spec.js 13:4 error Expected indentation of 2 spaces but found 3 indent 14:7 error Expected indentation of 5 spaces

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-05-01 Thread Ashesh Vashi
On Mon, Apr 30, 2018 at 11:27 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > You've lost us with the last reply. We'd love to know what we'd have to do > to get this patch committed. You mention that "some things are missing at > some places" and that "there are missing bits"

Re: Possibility to increase release frequency

2018-05-01 Thread Fahar Abbas
Hi Robert, As Dave already mentioned that we perform basic sanity with PostgreSQL and EDB(EPAS) servers. Here are some additional scenarios that you can also use with GreenPlum database testing: --- 1. pgAdmin4 Builds should be working fine on Fresh Virtual machines on all supported platforms win