Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

Hi Khushboo, I did some changes on your patch: 0001 - Your original patch 0002 - Convert keyboard.js to ES6 0003 - Refactoring of the keyboard.js file(some one letter variables and other code) Thanks Joao On Thu, Apr 26, 2018 at 5:34 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrot

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi Akshay, Some suggestions: - browser/server_groups/servers/__init__py This file could have been split into separate functionalities. There is a chunk of changes for connect, why not move that out? Same thing for create. Do we really need to have full integrationy tests that do a HTTP request a

pgAdmin 4 commit: Cleanup some old code that was failing CI.

Cleanup some old code that was failing CI. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=201f6d359ff61bf07544db844711f9b3fc4b881c Author: Joao Pedro De Almeida Pereira Modified Files -- web/pgadmin/utils/route.py | 3 ++- 1 file

Re: [pgadmin4][patch] Old code failing CI

Thanks, applied. On Thu, Apr 26, 2018 at 2:52 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > Attached you can find a patch of some leftover code that we didn't realize > was still there. > > Thanks > Joao > -- Dave Page Blog: http://pgsnake.blogspot.com Twi

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Hi Joao, On Wed, Apr 25, 2018 at 6:55 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi, > @Murtuza: We didn't notice the issue, can you please advise on what need > to change to make it work? The only change we did was to make one test pass. > I moved to another project so

[pgadmin4][patch] Old code failing CI

Hi Hackers, Attached you can find a patch of some leftover code that we didn't realize was still there. Thanks Joao old-code.patch Description: Binary data

Re: [pgadmin4][patch] [GreenPlum] Partitioned table icon is the same as non partitioned tables

Thanks Patch applied. On Wed, Apr 25, 2018 at 2:17 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > Attached you can find 2 patches that correct the Redmine: #3308 > A > Patches: > 0001 - In this patch we update the SQ

pgAdmin 4 commit: Fixed issue where icon for Partitioned tables was the

Fixed issue where icon for Partitioned tables was the same as Non Partitioned tables for GreenPlum database. Fixes #3308 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=966279c1b3cc9137ed6bb7ba21e76d0981178b3c Author: Joao De Almeida Pereira

[pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

Hi, Please find the attached patch to fix the RM #3284 : F5 key not working consistently. - Added the configurable keyboard shortcut (default F5) to refresh the browser tree nodes. Thanks, Khushboo diff --git a/web/pgadmin/browser/register_browser_preferences.py b/web/pgadmin/browser/register_b