JS Test error on Windows

2018-04-25 Thread Dave Page
Hi Setting up an new build system running Windows 2016 and I'm hitting an error with the JS tests as below. I have Yarn 1.6.0, Node 8.11.1 and get the following error running yarn run test:karma-once. The linter and bundler work fine, FWIW, and I see the same error running either manually or throu

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Joao De Almeida Pereira
Hi, @Murtuza: We didn't notice the issue, can you please advise on what need to change to make it work? The only change we did was to make one test pass. @Hackers: In our point of view it is never good to fork a library. But if he really have to do it, then we should fork it in Github, make our co

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Dave Page
On Wed, Apr 25, 2018 at 12:13 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Apr 25, 2018 at 3:36 PM, Dave Page wrote: > >> All, >> >> We just had a brief discussion in our EDB sprint planning meeting about >> this. There is a non-zero chance that we're

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Murtuza Zabuawala
Hi Dave, On Wed, Apr 25, 2018 at 3:36 PM, Dave Page wrote: > All, > > We just had a brief discussion in our EDB sprint planning meeting about > this. There is a non-zero chance that we're going to have to fork wcDocker > in the near future, in order to update it to work with jQuery 3. If we do >

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Dave Page
All, We just had a brief discussion in our EDB sprint planning meeting about this. There is a non-zero chance that we're going to have to fork wcDocker in the near future, in order to update it to work with jQuery 3. If we do that, then it may be significantly easier to fix this issue in that fork

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-25 Thread Murtuza Zabuawala
Hi Akshay, On Wed, Apr 25, 2018 at 2:37 PM, Akshay Joshi wrote: > Hi Joao/Murtuza > > It break's the functionality, I am able to move "Data output", "Explain" > etc.. panel of Query Tool, even if "Lock layout?" is set to True. > ​It's working properly in v5 patch, Something went wrong while re

[pgadmin4][Patch]: Test cases for the backup module

2018-04-25 Thread Khushboo Vashi
Hi, Please find the attached patch which covers test cases for the backup module (RM #3206). 1. Unit test cases 2. End to end regression test cases 3. Feature test cases Thanks, Khushboo diff --git a/web/pgadmin/feature_tests/pg_utilities_backup_test.py b/web/pgadmin/feature_tests/pg_utilities_b

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-04-25 Thread Dave Page
Ashesh; you had agreed to work on this early this week. Please ensure you do so today. Thanks. On Tue, Apr 24, 2018 at 8:13 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Can someone review and merge this patch? > > Thanks > Joao > > On Wed, Apr 18, 2018 at

Re: [pgadmin4][patch] [GreenPlum] Display SQL of table with index #3306

2018-04-25 Thread Akshay Joshi
Thanks patch applied. On Tue, Apr 24, 2018 at 2:29 PM, Akshay Joshi wrote: > > > On Tue, Apr 24, 2018 at 1:19 PM, Dave Page wrote: > >> Akshay, can you review/commit this please? (and update the release notes) >> > >Sure. > >> >> On Mon, Apr 23, 2018 at 2:49 PM, Joao De Almeida Pereira < >>

pgAdmin 4 commit: Fixed display SQL of table with index for GreenPlum d

2018-04-25 Thread Akshay Joshi
Fixed display SQL of table with index for GreenPlum database. Fixes #3306 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ace6a60f3d16a0202b8ef8fdeb5218846e2bc0e Author: Joao De Almeida Pereira Modified Files -- docs/en_US/releas