Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi Joao On Tue, Apr 24, 2018 at 10:04 PM, Joao De Almeida Pereira wrote: > Hi Akshay, > > After looking through the patch we found some one letter variable names > and this is a regression on what we have been trying to accomplish in the > last year. > > An objective that we have for pgAdmin sou

[pgadmin4][patch] [GreenPlum] Partitioned table icon is the same as non partitioned tables

Hi Hackers, Attached you can find 2 patches that correct the Redmine: #3308 A Patches: 0001 - In this patch we update the SQL to retrieve the is_partitioned flag from the database 0002 - Extract and refactor the icon css class retrieval. It was scattered

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Hackers, Can someone review and merge this patch? Thanks Joao On Wed, Apr 18, 2018 at 10:23 AM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > Any other comment about this patch? > > Thanks > Joao > > On Tue, Apr 10, 2018 at 12:00 PM Joao De Almeida Pereira < >

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi Akshay, After looking through the patch we found some one letter variable names and this is a regression on what we have been trying to accomplish in the last year. An objective that we have for pgAdmin source code is to increase the testability of it and make it more readable. If we keep on a

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Thank you Joao for reviewing. On Tue, Apr 24, 2018 at 9:11 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > haha, > Just joking, now we have a good version that passes tests and all. > > We found out that a test was failing in the patch version 5: > > HeadlessChrome 0.0.0 (Li

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Hi Murtuza, We tested the patch and everything looks fine. We also refactors some parts to include things like strict equality and using let/const instead of var. The updated patch is attached. In the future, it will be more valuable to have the translation to ES6 and the feature work in separat

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi Hackers As per suggestion by Dave, I have moved "Advanced" tab at the last for Server dialog. Attached is the modified patch. On Mon, Apr 23, 2018 at 7:32 PM, Anthony Emengo wrote: > For what it is worth, I manually verified that the feature worked, as well > as looked through the code. > >

Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server

Thanks patch applied On Tue, Apr 24, 2018 at 2:29 PM, Akshay Joshi wrote: > > > On Tue, Apr 24, 2018 at 1:47 PM, Dave Page wrote: > >> Akshay, can you review/commit this please? >> > >Sure. > >> >> Thanks. >> >> On Mon, Apr 23, 2018 at 3:34 PM, Anthony Emengo >> wrote: >> >>> Just manually

pgAdmin 4 commit: Close button added to the alertify message box, which

Close button added to the alertify message box, which pops up in case of backend error. Fixes #3290 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b653b742ede0e6d30ebb4ec03b8cbb2e0f993478 Author: Ashesh Vashi Modified Files -- w

Re: [pgadmin4][patch] [GreenPlum] Display SQL of table with index #3306

On Tue, Apr 24, 2018 at 1:19 PM, Dave Page wrote: > Akshay, can you review/commit this please? (and update the release notes) > Sure. > > On Mon, Apr 23, 2018 at 2:49 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> Attached you can find the patch that

Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server

On Tue, Apr 24, 2018 at 1:47 PM, Dave Page wrote: > Akshay, can you review/commit this please? > Sure. > > Thanks. > > On Mon, Apr 23, 2018 at 3:34 PM, Anthony Emengo > wrote: > >> Just manually verified that this worked, and the patch successfully went >> through our pipelines. >> >> Thank

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Tue, Apr 24, 2018 at 1:17 PM, Dave Page wrote: > Akshay, could you review/commit this please? > > Please also update the release_notes_3_1.rst file when you commit > user-visible changes, to make it easier to build the release notes. > Sure > > Thanks. > > On Tue, Apr 24, 2018 at 8:45 AM,

Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server

Akshay, can you review/commit this please? Thanks. On Mon, Apr 23, 2018 at 3:34 PM, Anthony Emengo wrote: > Just manually verified that this worked, and the patch successfully went > through our pipelines. > > Thanks so much for fixing this issue! > > - Joao and Anthony > > On Mon, Apr 23, 2018

Re: [pgadmin4][patch] [GreenPlum] Display SQL of table with index #3306

Akshay, can you review/commit this please? (and update the release notes) On Mon, Apr 23, 2018 at 2:49 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > Attached you can find the patch that corrects the rm - 3306. > Also adds some tests around the behavior of the

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Akshay, could you review/commit this please? Please also update the release_notes_3_1.rst file when you commit user-visible changes, to make it easier to build the release notes. Thanks. On Tue, Apr 24, 2018 at 8:45 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, >