Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi Hackers, On Mon, Apr 23, 2018 at 9:07 PM, Anthony Emengo wrote: > We also tried running the tests with this patch. It didn't launch without > some code changes and several tests were failing. We should really defer > pulling this in until we have more robust results on Firefox > > In order to

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

We also tried running the tests with this patch. It didn't launch without some code changes and several tests were failing. We should really defer pulling this in until we have more robust results on Firefox In order to have the tests running we had to do the following change: diff --git a/web/re

Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server

Just manually verified that this worked, and the patch successfully went through our pipelines. Thanks so much for fixing this issue! - Joao and Anthony On Mon, Apr 23, 2018 at 3:40 AM, Ashesh Vashi wrote: > Hi Team, > > Please find the patch for fixing the RM #3290. > The 'Close button' was m

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

For what it is worth, I manually verified that the feature worked, as well as looked through the code. I'd like to see end-to-end testing for regression sake, but it's hard to so at this moment. - Anthony and Joao. On Mon, Apr 23, 2018 at 5:09 AM, Akshay Joshi wrote: > > > On Mon, Apr 23, 2018

[pgadmin4][patch] [GreenPlum] Display SQL of table with index #3306

Hi Hackers, Attached you can find the patch that corrects the rm - 3306. Also adds some tests around the behavior of the wrapping function of the table controller. Thanks Anthony & Joao diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/tests/test_utils.py b/web/pgadmi

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi On Mon, Apr 23, 2018 at 2:05 PM, Akshay Joshi wrote: > Hi Hackers, > > I have added support for running feature tests against FireFox. For that > user will have to download gecko driver from https://github.com/mozilla/ > geckodriver/releases and follow the below steps: > >- Extract the ge

[pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi Hackers, I have added support for running feature tests against FireFox. For that user will have to download gecko driver from https://github.com/mozilla/ geckodriver/releases and follow the below steps: - Extract the gecko driver. - Run chmod +x geckodriver. - Either copy the geckodr

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

On Mon, Apr 23, 2018 at 1:30 PM, Dave Page wrote: > Hi > > On Thu, Apr 19, 2018 at 6:56 PM, Anthony Emengo > wrote: > >> Hey Akshay >> >> This patch passed our test pipelines. >> > > Did you test the feature and//or review the code and tests? Passing the > tests is great, *if* the whole feature

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi On Thu, Apr 19, 2018 at 6:56 PM, Anthony Emengo wrote: > Hey Akshay > > This patch passed our test pipelines. > Did you test the feature and//or review the code and tests? Passing the tests is great, *if* the whole feature is covered (and the nature of this patch will make that quite difficu

[PATCH] [RM# 3290] Close button missing for the message window from the backend server

Hi Team, Please find the patch for fixing the RM #3290. The 'Close button' was missing in the message box, which shows the error in the backend server. This patch also fixes some of the missing keycode 'ESCAPE' on 'Cancel' buttons in different modules. Please review. -- Thanks & Regards, Ashe