Re: pgAdmin 3.0 builds

2018-04-12 Thread Fahar Abbas
Hi Dave, I have finished one round of sanity testing for pgAdmin4 3.0 and no issue found during verification and it's ready for the release. Kind Regards, On Thu, Apr 12, 2018 at 7:14 PM, Dave Page wrote: > Hi > > On Thu, Apr 12, 2018 at 2:29 PM, Joao De Almeida Pereira < > jdealmeidapere...@p

Re: pgAdmin 3.0 builds

2018-04-12 Thread Dave Page
Hi On Thu, Apr 12, 2018 at 2:29 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Dave, > Did you remove the folder with the builds? > Yes, when I re-built everything. It's now at: https://developer.pgadmin. org/~dpage/v3.0-2/ > What is the git SHA from which the release

Re: pgAdmin 3.0 builds

2018-04-12 Thread Joao De Almeida Pereira
Hi Dave, Did you remove the folder with the builds? What is the git SHA from which the release is going to be created from? Thanks Joao On Thu, Apr 12, 2018 at 4:08 AM Dave Page wrote: > Hi > > On Wed, Apr 11, 2018 at 6:08 PM, Christoph Berg wrote: > >> Re: Dave Page 2018-04-11 < >> ca+ocxoxvs

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Dave Page
Thanks - patch applied! On Thu, Apr 12, 2018 at 11:52 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Apr 12, 2018 at 3:45 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA updated patch which includes procedure and functions of ppas. Other >> no

pgAdmin 4 commit: Fix an error generating SQL for trigger functions. Fi

2018-04-12 Thread Dave Page
Fix an error generating SQL for trigger functions. Fixes #3179 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5fdd329717d0efe5a521b35bda41d7d04024115 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_3_1.rst

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Khushboo Vashi
On Thu, Apr 12, 2018 at 3:45 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA updated patch which includes procedure and functions of ppas. Other > nodes works fine. > > Looks good to me. > On Thu, Apr 12, 2018 at 2:59 PM, Aditya Toshniwal enterprisedb.com>

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Aditya Toshniwal
Hi Hackers, PFA updated patch which includes procedure and functions of ppas. Other nodes works fine. On Thu, Apr 12, 2018 at 2:59 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Khushboo, > > Looks like that need to be fixed too. It is not because of the new patch. > Will

pgAdmin 4 commit: Catch errors when trying to EXPLAIN an invalid query.

2018-04-12 Thread Dave Page
Catch errors when trying to EXPLAIN an invalid query. Fixes #3257 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c08adb5567f52be95435fa8bd055233d1435ae50 Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes.rst

Re: [pgAdmin4][RM#3257] Fix for explain functionality

2018-04-12 Thread Dave Page
Thanks, applied. On Tue, Apr 10, 2018 at 6:57 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thanks for reviewing Joao. > > Yeah missed to run tests. I assumed its just a SQL formatting it wouldn't > hurt anything but I was wrong :) > Here's updated patch. > > -- > Regards,

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Aditya Toshniwal
Hi Khushboo, Looks like that need to be fixed too. It is not because of the new patch. Will send you the updated patch. On Thu, Apr 12, 2018 at 2:47 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Aditya, > > On Thu, Apr 12, 2018 at 2:30 PM, Aditya Toshniwal enterprisedb.com>

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Khushboo Vashi
Hi Aditya, On Thu, Apr 12, 2018 at 2:30 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PPAS SQL also needs to changed. PFA updated patch. > > The trigger function SQL panel is working now but the function SQL panel is broken. > On Thu, Apr 12, 2018 at 2:14 PM,

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Aditya Toshniwal
Hi Hackers, PPAS SQL also needs to changed. PFA updated patch. On Thu, Apr 12, 2018 at 2:14 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Team, > > Please hold on with the patch. Checking if changes are required for PPAS. > Will update soon. > > On Thu, Apr 12, 2018 at 12

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Aditya Toshniwal
Hi Team, Please hold on with the patch. Checking if changes are required for PPAS. Will update soon. On Thu, Apr 12, 2018 at 12:18 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Team, > > PFA patch for RM#3179 where error message was displayed when user selects > the SQL t

Re: pgAdmin 3.0 builds

2018-04-12 Thread Dave Page
Hi On Wed, Apr 11, 2018 at 6:08 PM, Christoph Berg wrote: > Re: Dave Page 2018-04-11 3gxohw0oitv-ha4_ssn+23a0...@mail.gmail.com> > > New builds are at https://developer.pgadmin.org/~dpage/v3.0-2/. > > > > These fix the Windows crash that Fahar found (which happened if the user > > had a space i