Re: [pgAdmin4][RM#3154] Update modules to latest version

Thanks for reviewing Victoria. On Fri, Mar 30, 2018 at 7:59 PM, Victoria Henry wrote: > Hi Murtuza, > > I ran this patch through the pipelines and all tests passed. > Everything looks good. > > Sinerely, > > Victoria > > On Fri, Mar 30, 2018 at 3:01 AM, Murtuza Zabuawala enterprisedb.com> wrote

Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

Then that's browser specific issue, please create one redmine ticket for the issue.​ On Fri, Mar 30, 2018 at 11:36 PM, Rahul Soshte wrote: > Yeah the code is present.I have attached the screenshot. > Also I have noticed that the format combobo

Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

​I don't think so, Could you inspect html/css code on 'Save as' dialog within your browser window and see if it's present or not?​ On Fri, Mar 30, 2018 at 8:30 PM, Rahul Soshte wrote: > Hi, > I don't know why that combobox is not seen in my environment.I am using > Ubuntu 17.10.I have attached

Re: [pgAdmin4][RM#3154] Update modules to latest version

Hi Murtuza, I ran this patch through the pipelines and all tests passed. Everything looks good. Sinerely, Victoria On Fri, Mar 30, 2018 at 3:01 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to update the modules to latest version. > > We are not able to

Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

++ Attaching screenshot On Fri, Mar 30, 2018 at 7:06 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Rahul, > > When I said .sql extension, I meant selected sql option in 'Format' > combobox (check the screenshot I've attached) > > For the error you've mentioned you can cr

Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

Hi Rahul, When I said .sql extension, I meant selected sql option in 'Format' combobox (check the screenshot I've attached) For the error you've mentioned you can create Fake application context. Ref: ../web/pgadmin/dashboard/tests/test_dashboard_templates.py +274 -- Regards, Murtuza Zabuawala E

Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

Hi, I tried writing tests in the web/pgadmin/tools/sqleditor/ utils/tests/test_save_query_to_file_utils for the file web/pgadmin/tools/sqleditor/utils/tests/save_query_to_ file_utils.py But I am getting a error, ERROR: runTest (pgadmin.tools.sqleditor.utils.tests.test_save_query_ to_file_utils.Te

Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

On Thu, Mar 29, 2018 at 11:45 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Rahul, > I see you extracted some code, that is a pretty good move :D > > We run the patch through the testing pipeline and everything is green GJ :D > Also tested the functionality by hand and lo

[pgAdmin4][RM#3154] Update modules to latest version

Hi, PFA patch to update the modules to latest version. We are not able to update some of the modules to latest version due to dependancy on other modules, For example - Python: Flask-Security has dependancy on flask-babelex which causes conflict with flask_babel - JS: Can't update to Bootstrap4 b