Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

Hi Rahul, I see you extracted some code, that is a pretty good move :D We run the patch through the testing pipeline and everything is green GJ :D Also tested the functionality by hand and looks like it is working except for "add the .sql extension when format is set to SQL." if you set it to All

Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

On Thu, Mar 29, 2018 at 12:45 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thanks Akshay & Joao, got it. > > My bad sorry for the noise. > The question helped me, nothing wrong with questions. -- Rob > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enter

Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

Thanks Akshay & Joao, got it. My bad sorry for the noise. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Mar 29, 2018 at 9:06 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > Lets imagine you h

Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

Hi Murtuza, Lets imagine you have CREATE TABLE cities ( city_id bigserial not null, name text not null, population int ) PARTITION BY LIST (initcap(name)); CREATE TABLE cities_west PARTITION OF cities ( CONSTRAINT city_id_nonzero CHECK (city_id != 0) ) FOR VA

Re: Bug #3083 fix

Hi Dave, That looks like in the surrounding area of the change. We run our pipeline and everything was green. Can you provide more details, which python version are you using? OS? Thanks Joao On Thu, Mar 29, 2018 at 9:03 AM Dave Page wrote: > Hi > > On Wed, Mar 28, 2018 at 7:06 PM, Joao De Alme

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Hi Murtuza, After changing the setting in the preferences nothing happened, we had to reset the layout or refresh the app to see it working. It only looks the right side. Was this the intended behavior? Not sure if this is the expected behavior or not. I would expect that any change I do in the p

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Khushboo, The patch looks like it is heading on the correct direction, we passed it through our test pipeline and all tests passed. We found the same issues as Dave mentioned in his email, also after some code review we have the following questions/comments: . Why does modify_animation.js hav

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Mar 26, 2018 at 6:07 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attac

Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

Thanks, applied. On Thu, Mar 29, 2018 at 1:35 PM, Akshay Joshi wrote: > Hi Hackers, > > Please find the attached patch to fix RM #3180 Index node is missing from > the tree view of the table node. This is a regression of one of the older > commit. > > -- > *Akshay Joshi* > > *Sr. Software Archit

pgAdmin 4 commit: Fix index node display on PG 10. Fixes #3180

Fix index node display on PG 10. Fixes #3180 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=61eb94a23c043930034d66a18ea1189343f0ee8a Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_0.rst

Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

Hi Akshay, I have concerns regarding the fix, As you negate the condition, Before the fix it was not displaying Index node for Tables but after the fix it will not display it for Partition tables. But when I read the Postgres docs it say, *Partitions may themselves be defined as partitioned tables

Re: Bug #3083 fix

Hi On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hey Akshay and Neethu > > We refactored the patch to add tests for the resize feature. We were able > to write test cases for the drag event by using spies and setting the rect > dimensions. In

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Joao, On Tue, Mar 27, 2018 at 12:12 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Khushboo, > > Looks like you have a typo on your CSS where it reads 'zoomeIn' it should > be 'zoomIn'. > Thanks, I have sent the updated patch. > Also setting more parameters into the w

[pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

Hi Hackers, Please find the attached patch to fix RM #3180 Index node is missing from the tree view of the table node. This is a regression of one of the older commit. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3180.patch Description: B

Re: Bug #3083 fix

Thanks Joao. On Wed, Mar 28, 2018 at 11:36 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hey Akshay and Neethu > > We refactored the patch to add tests for the resize feature. We were able > to write test cases for the drag event by using spies and setting the rect > dimen