Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL

Hi Joao On Tue, Mar 27, 2018 at 12:01 AM, Joao De Almeida Pereira wrote: > Hello, > We tried to reproduce the issue but we were not capable to reproduce it. > What it is strange on the fix is that python is complaining about a > different line then the one that was fixed. Maybe this is just a Py

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > @Murtuza: The patch codewise looks good. Nice to see that we are using > axios instead of jquery ajax calls and that there is some coverage for the > change. > Nevertheless the Javascr

Re: Trying to work on a feature.

Hello Rahul, This issues looks like it is located in the file pgadmin/tools/sqleditor/__init__.py in the function save_file Maybe around the code: # generate full path of file file_path = unquote(file_data['file_name']) if hasattr(str, 'decode'): file_path = unquote( file_data['file_n

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Khushboo, Looks like you have a typo on your CSS where it reads 'zoomeIn' it should be 'zoomIn'. Also setting more parameters into the window, in our experience, is never good, so maybe it is time to create a real settings cache that can retrieve from the backend the settings, like this one. T

Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL

Hello, We tried to reproduce the issue but we were not capable to reproduce it. What it is strange on the fix is that python is complaining about a different line then the one that was fixed. Maybe this is just a Python thing I assume that the fix works, but I would love to see some tests to e

Trying to work on a feature.

I am new to the codebase of pgAdmin4 and I am trying to work on this Feature. https://redmine.postgresql.org/issues/1998 which appends .sql to files when using the feature "Save" or "Save As" Which files or folders I should be mostly grasping or looking at ?

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

Hi Hackers, @Murtuza: The patch codewise looks good. Nice to see that we are using axios instead of jquery ajax calls and that there is some coverage for the change. Nevertheless the Javascript testing looks a bit slim and could be improved. Also the DataSorting class could have some other member

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

On Mon, Mar 26, 2018 at 5:52 PM, Dave Page wrote: > Hi > > On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which allow user to sort the data in View data mode. >> > > The patch looks good in general, however I'm not sure about the UI, in > par

Re: v3.0 release on hold

Hi Hackers, Did we had any progress on the things that are holding the release back? Thanks Joao On Fri, Mar 23, 2018 at 9:26 AM Akshay Joshi wrote: > Hi Dave > > On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 22, 2018 at 10:24 P

Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL

Thanks, applied. On Mon, Mar 26, 2018 at 11:43 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch to fix RM #3090 pgadmin shows misleading > "Query returned successfully" with incorrect SQL. > > -- > *Akshay Joshi* > > *Sr. Software Architect

pgAdmin 4 commit: Decode the severity field in database exception objec

Decode the severity field in database exception objects properly. Fixes #3090 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1baddd5e9a8d66daefa4c9e1b6a6ba10ba1130ea Author: Akshay Joshi Modified Files -- docs/en_US/release_notes

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #1978: Add an option to allow > user to disable alertifyjs and acitree animations. > I think these really need to be per-user settings, not per-installa

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

Hi On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch which allow user to sort the data in View data mode. > The patch looks good in general, however I'm not sure about the UI, in particular that the closely-linked dialogue for fil

[pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL

Hi Hackers, Please find the attached patch to fix RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3090.patch Description: Binary data