Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

On Thu, Mar 15, 2018 at 3:21 AM, Dave Page wrote: > Hi > > On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> > > Can you add a unit test for set_env_variables() please? > > This function is a part

Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t

Thanks, applied. On Wed, Mar 14, 2018 at 12:10 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Khushboo, > Good catch, attached you can find the fix for the problem. > > Thanks > Victoria & Joao > > On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi < > khushboo.va...@enterpr

pgAdmin 4 commit: Fix trim function which was causing some JS errors du

Fix trim function which was causing some JS errors during Server Properties validation. Victoria & Joao Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c4359270ebdcdbdedce639491a362f4f5d7198b Author: Joao Pedro De Almeida Pereira Modified F

Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

Hi On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > Can you add a unit test for set_env_variables() please? > > Thanks, > Khushboo > > On Wed, Mar 14, 2018 at 1:07 PM, Khushboo Vashi < > khushboo.va..

Re: [postgis-users] Rahul Soshte GSOC Draft Proposal

@Jo I fixed the typo.This proposal is for OSGEO.To clarify,I will be submitting another proposal to OpenStreetMap also. On Wed, Mar 14, 2018 at 10:54 PM, Jo wrote: > Hi Rahul, > > I only made some minor suggestions. The proposal looks fine to me. At the > end you state you only submit a proposal

Re: [postgis-users] Rahul Soshte GSOC Draft Proposal

Hi Rahul, I only made some minor suggestions. The proposal looks fine to me. At the end you state you only submit a proposal to OpenStreetMap organisation, which is a bit confusing, as I got the impression you were proposing this for OSGeo? Polyglot (from OpenStreetMap, not OSGeo, but with a vest

Rahul Soshte GSOC Draft Proposal

Hi, This is Rahul Soshte a student from Vivekanand Education Society's Institute of Technology(Mumbai,India). The proposal is for the idea of a a Geospatial query viewer for pgadmin4 mentioned here I have uploaded the draft proposal on t

Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t

Hi Khushboo, Good catch, attached you can find the fix for the problem. Thanks Victoria & Joao On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao/Victoria, > > I am getting an error while editing the server properties. Please refer > the attached

Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

Hi, Please find the attached updated patch. Thanks, Khushboo On Wed, Mar 14, 2018 at 1:07 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> ../pgadmin4/web/pgadmin/tools/import_export/__init__.p

Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without > your patch applied. > > Yes, good point. Will update and send the patch. > > On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawa

Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without your patch applied. On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Khushboo, > > We can simplify this, we don't need to create any extra column, > > Check: ../pgadmin4/web

Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

Hi Khushboo, We can simplify this, we don't need to create any extra column, Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322 where we are setting ENV variable we can create common utility function (let say in ../tools/utils/__init__.py) which will set all required the environm