Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

On Tue, Mar 6, 2018 at 8:35 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > > All tests pass on CI, and the code looks good. The only issue that I found > was the line: > os.path.dirname(os.path.realpath(__file__)) + "/../templates" > > that will not work on

[pagdmin][patch] Update jasmine #3182

Hi Hackers, Attached you can find the patch that updates the version of jasmine to 3.0 Thanks Joao diff --git a/web/package.json b/web/package.json index 2707b334..a4cb58d5 100644 --- a/web/package.json +++ b/web/package.json @@ -18,7 +18,7 @@ "file-loader": "^0.11.2", "image-webpack-lo

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

Hello, I just sent a video that talks exactly about this, in the journey to have a more maintainable code and easier to navigate, we sometimes increase complexity for a period of time in order to get to the state that we want to be. In particular in this example I tried the following: 1. Demonstr

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Hi Murtuza, The code change works, and I passed the patches through our pipeline and everything is green. Personally I would love this bug fixes to have refactored the function into smaller chunk and made it more readable so that the next time someone need to check out a problem in the same area i

Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

Hello Khushboo, All tests pass on CI, and the code looks good. The only issue that I found was the line: os.path.dirname(os.path.realpath(__file__)) + "/../templates" that will not work on windows. So I updated your patch with the change and it should be ready to merge. Thanks Joao On Tue, Ma

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

Hello Khushboo, Thanks for the changes here. Now everything looks good, and the tests all pass. Thanks Joao On Tue, Mar 6, 2018 at 5:09 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Mon, Mar 5, 2018 at 8:42 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: >

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

Hello Neel, You can find attached the corrections of the path's needed for windows. The fix should correct TestExternalTablesView and TestTemplateCreate but for the ChangePasswordTestCase I need more information to help you out. We need to understand what is the response that the endpoint /user_ma

Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

Hi Joao, Thanks for reviewing. On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Kushboo, > > Can we add some Unit test to ensure this does not happen again? > > Please find the attached patch with the unit tests. > Thanks > Joao > > Thanks,

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

On Mon, Mar 5, 2018 at 8:42 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > Looks like we are almost doen, just missing one PEP-8 issue: > → pycodestyle --config=.pycodestyle pgadmin/tools > pgadmin/tools/sqleditor/tests/test_poll_query_tool.py:46: [E126] > c

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

Hi On Tue, Mar 6, 2018 at 6:59 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Joao, > > Your suggestion is good but in my own opinion it is overkill just to > replace code {{ username| gravatar }} as rest of the syntax is pure HTML, > This makes code much simpler and easy

[pgAdmin4][RM#2989] To fix the issue in Table node

Hi, PFA patch to fix the issue in Table node where wrong sql was generated while altering column. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2989.diff Description: Binary data fix_table_node_PEP8.diff Description: Binary data